Skip to content

Restore UIKit import to FIRApp.h to prevent breaking change #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2017
Merged

Restore UIKit import to FIRApp.h to prevent breaking change #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Firebase/Core/FIRApp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@

#import <Foundation/Foundation.h>

#if TARGET_OS_IOS
// TODO: Remove UIKit import on next breaking change release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this TODO?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like a good thing for us since we shouldn't unnecessarily drag UIKit in and to let clients know that it will go away.

#import <UIKit/UIKit.h>
#endif

#import "FIRCoreSwiftNameSupport.h"

@class FIROptions;
Expand Down