Skip to content

Add FieldValue.boolean_value() #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Add FieldValue.boolean_value() #862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Firestore/core/src/firebase/firestore/model/field_value.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,11 @@ class FieldValue {
return tag_;
}

bool boolean_value() const {
FIREBASE_ASSERT(tag_ == Type::Boolean);
return boolean_value_;
}

int64_t integer_value() const {
FIREBASE_ASSERT(tag_ == Type::Integer);
return integer_value_;
Expand Down
7 changes: 1 addition & 6 deletions Firestore/core/src/firebase/firestore/remote/serializer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,12 +131,7 @@ void Serializer::EncodeFieldValue(const FieldValue& field_value,
// TODO(rsgowman): figure out error handling
abort();
}
if (field_value == FieldValue::TrueValue()) {
EncodeBool(&stream, true);
} else {
FIREBASE_DEV_ASSERT(field_value == FieldValue::FalseValue());
EncodeBool(&stream, false);
}
EncodeBool(&stream, field_value.boolean_value());
break;

case FieldValue::Type::Integer:
Expand Down