Skip to content

Conversation

wilhuff
Copy link
Contributor

@wilhuff wilhuff commented Mar 7, 2018

Use revision ranges in all source checking commands. Cumulative time for all checks down from 16s to 0.3s.

Other cleanup:

  • Factor out scripts so they can be tested stand-alone
  • Group all source checks first to fail builds without building

@wilhuff wilhuff force-pushed the wilhuff/travis-ranges branch from 3d38caf to fd9eee5 Compare March 7, 2018 16:49
@wilhuff wilhuff requested a review from paulb777 March 7, 2018 16:56
@wilhuff wilhuff assigned wilhuff and paulb777 and unassigned wilhuff Mar 7, 2018
@wilhuff wilhuff merged commit b7750b5 into master Mar 7, 2018
@wilhuff wilhuff deleted the wilhuff/travis-ranges branch March 7, 2018 17:59
minafarid pushed a commit to minafarid/firebase-ios-sdk that referenced this pull request Jun 6, 2018
* Factor out a whitespace checking script

* Factor out a copyright checking script

* Rewrite lint.sh to honor revision ranges

* Only restyle files that are part of the PR

* Run C++ lint before builds to fail faster

* Git grep doesn't operate on revision ranges

* style.sh accepts clang-format 6 or 7
@firebase firebase locked and limited conversation to collaborators Nov 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants