Move isPrimary assert to the spec test runner (#1080)

Author: schmidt-sebastian

packages/firestore/test/unit/specs/spec_builder.ts

@@ -862,11 +862,6 @@ export class SpecBuilder {
 
   protected nextStep(): void {
     if (this.currentStep !== null) {
-      if (this.config.numClients === 1) {
-        // Always verify that we are the primary client if there is only one
-        // client.
-        this.expectPrimaryState(true);
-      }
       this.steps.push(this.currentStep);
       this.currentStep = null;
     }

packages/firestore/test/unit/specs/spec_test_runner.ts

@@ -371,6 +371,7 @@ abstract class TestRunner {
   private persistence: Persistence;
   private sharedClientState: SharedClientState;
   private useGarbageCollection: boolean;
+  private numClients: number;
   private databaseInfo: DatabaseInfo;
 
   protected user = User.UNAUTHENTICATED;
@@ -402,6 +403,7 @@ abstract class TestRunner {
     });
 
     this.useGarbageCollection = config.useGarbageCollection;
+    this.numClients = config.numClients;
 
     this.expectedLimboDocs = [];
     this.expectedActiveTargets = {};
@@ -943,10 +945,7 @@ abstract class TestRunner {
         this.expectedActiveTargets = expectation.activeTargets!;
       }
       if ('isPrimary' in expectation) {
-        expect(this.syncEngine.isPrimaryClient).to.eq(
-          expectation.isPrimary!,
-          'isPrimary'
-        );
+        expect(this.isPrimaryClient).to.eq(expectation.isPrimary!, 'isPrimary');
       }
       if ('userCallbacks' in expectation) {
         expect(this.acknowledgedDocs).to.have.members(
@@ -958,6 +957,10 @@ abstract class TestRunner {
       }
     }
 
+    if (this.numClients === 1) {
+      expect(this.isPrimaryClient).to.eq(true, 'isPrimary');
+    }
+
     // Clients don't reset their limbo docs on shutdown, so any validation will
     // likely fail.
     if (this.started) {