Skip to content

Move isPrimary assert to the spec test runner #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2018
Merged

Move isPrimary assert to the spec test runner #1080

merged 1 commit into from
Aug 1, 2018

Conversation

schmidt-sebastian
Copy link
Contributor

Move isPrimary assert to the spec test runner to reduce size of JSON output.

@schmidt-sebastian schmidt-sebastian merged commit fbcfeef into firestore-multi-tab Aug 1, 2018
@schmidt-sebastian schmidt-sebastian deleted the multitab-moveassert branch August 3, 2018 17:15
@firebase firebase locked and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff Awaiting requested review from wilhuff

1 more reviewer

@mikelehen mikelehen mikelehen approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@schmidt-sebastian schmidt-sebastian

Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @mikelehen @google-oss-bot