Skip to content

Roll back to 6.2.1 and add RN and XMLHttpRequest fixes #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2019
Merged

Roll back to 6.2.1 and add RN and XMLHttpRequest fixes #1909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2207b2d
Roll back import of newer AsyncStorage (#1902)
hsubox76 Jun 21, 2019
4670d00
Fix XMLHttpRequest import
hsubox76 Jun 24, 2019
ada5ec8
Remove extra character
hsubox76 Jun 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/app/index.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import { createFirebaseNamespace } from './src/firebaseNamespace';
// @ts-ignore
import Storage from 'dom-storage';
// @ts-ignore
import XMLHttpRequest from 'xmlhttprequest';
import { XMLHttpRequest } from 'xmlhttprequest';

const _firebase = createFirebaseNamespace() as _FirebaseNamespace;

Expand Down
15 changes: 2 additions & 13 deletions packages/app/index.rn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,8 @@ import { createFirebaseNamespace } from './src/firebaseNamespace';
* some of our tests because of duplicate symbols, we are using require syntax
* here
*/
// eslint-disable-next-line @typescript-eslint/no-explicit-any
let AsyncStorage: any;

try {
// eslint-disable-next-line @typescript-eslint/no-require-imports
AsyncStorage = require('@react-native-community/async-storage');
} catch (e) {
if (e.code !== 'MODULE_NOT_FOUND') {
throw e;
}
// eslint-disable-next-line @typescript-eslint/no-require-imports
AsyncStorage = require('react-native').AsyncStorage;
}
// eslint-disable-next-line @typescript-eslint/no-require-imports
const { AsyncStorage } = require('react-native');

const _firebase = createFirebaseNamespace() as _FirebaseNamespace;

Expand Down