Dependencies Update #528
Merged
Dependencies Update #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshcrowthe
requested review from
bojeil-google,
gauntface,
mikelehen,
ryanpbrewster,
schmidt-sebastian,
sphippen,
TMSCH,
tonymeng,
wilhuff and
wti806
as code owners
ryanpbrewster
approved these changes
Feb 21, 2018
gauntface
approved these changes
Feb 21, 2018
bojeil-google
approved these changes
Feb 22, 2018
mikelehen
approved these changes
Feb 22, 2018
There was a problem hiding this comment.
Looks good. What release will this go into? GRPC has broken us in the past so I'd like to know what release to watch out for issues in.
Also, it would be my preference that in the future we upgrade typescript and prettier as isolated PRs since they necessitate code changes in addition to just bumping the version. No need to mix unrelated changes in a single PR.
|
@mikelehen Good point. Moving forward I'll separate those out! The changes should manifest in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping all of our dependencies up to date across all packages.
Most of the packages were able to be updated without changing anything. There were two minor exceptions:
grpc: This required some updates to Firestore (they refactored one of the APIs into a generic in one of the later versions) but they were fairly minor fixes.prettier: They refactored how they handle particularly large strings with regards to line length.