Skip to content

Add Overlays and DocumentOverlayCache implementation #5969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Feb 12, 2022
Merged

Add Overlays and DocumentOverlayCache implementation #5969

merged 18 commits into from
Feb 12, 2022

Conversation

ehsannas
Copy link
Contributor

@ehsannas ehsannas commented Feb 2, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 555f3c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 2, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (c1b9cf1)Merge (f1d3267)Diff
    browser233 kB237 kB+4.50 kB (+1.9%)
    esm5291 kB296 kB+5.12 kB (+1.8%)
    main463 kB471 kB+8.35 kB (+1.8%)
    module233 kB237 kB+4.50 kB (+1.9%)
    react-native233 kB237 kB+4.50 kB (+1.9%)

  • @firebase/firestore-lite

    TypeBase (c1b9cf1)Merge (f1d3267)Diff
    browser72.8 kB72.9 kB+109 B (+0.1%)
    esm586.1 kB86.2 kB+153 B (+0.2%)
    main125 kB125 kB+109 B (+0.1%)
    module72.8 kB72.9 kB+109 B (+0.1%)
    react-native73.0 kB73.1 kB+109 B (+0.1%)

  • bundle

    12 size changes

    TypeBase (c1b9cf1)Merge (f1d3267)Diff
    firestore (Persistence)234 kB238 kB+4.50 kB (+1.9%)
    firestore (Query Cursors)190 kB192 kB+2.05 kB (+1.1%)
    firestore (Query)191 kB193 kB+2.05 kB (+1.1%)
    firestore (Read data once)179 kB181 kB+2.05 kB (+1.1%)
    firestore (Realtime updates)181 kB183 kB+2.05 kB (+1.1%)
    firestore (Transaction)164 kB166 kB+2.04 kB (+1.2%)
    firestore (Write data)163 kB165 kB+2.04 kB (+1.3%)
    firestore-lite (Query Cursors)56.7 kB56.8 kB+109 B (+0.2%)
    firestore-lite (Query)59.7 kB59.8 kB+109 B (+0.2%)
    firestore-lite (Read data once)44.2 kB44.3 kB+109 B (+0.2%)
    firestore-lite (Transaction)61.5 kB61.6 kB+109 B (+0.2%)
    firestore-lite (Write data)47.0 kB47.1 kB+109 B (+0.2%)

  • firebase

    TypeBase (c1b9cf1)Merge (f1d3267)Diff
    firebase-compat.js758 kB762 kB+4.45 kB (+0.6%)
    firebase-firestore-compat.js285 kB289 kB+4.45 kB (+1.6%)
    firebase-firestore-lite.js249 kB250 kB+316 B (+0.1%)
    firebase-firestore.js784 kB795 kB+10.6 kB (+1.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Ipa9EaE72I.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 2, 2022 •
edited
Loading

Size Analysis Report 1

This report is too large (521,295 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/OFiunkwN3K.html

@ehsannas ehsannas requested review from wu-hui and dconeybe and removed request for wu-hui February 3, 2022 02:35
schmidt-sebastian
schmidt-sebastian reviewed Feb 3, 2022
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good! I hope it was a fun learning opportunity :)

@ehsannas
Copy link
Contributor Author

ehsannas commented Feb 9, 2022

It was a great learning opportunity indeed

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2022 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@ehsannas ehsannas requested a review from egilmorez as a code owner February 9, 2022 04:30
schmidt-sebastian
schmidt-sebastian reviewed Feb 9, 2022
View reviewed changes
packages/firestore/src/local/indexeddb_schema.ts Outdated
static keyPath = ['userId', 'collectionPath', 'documentId'];

static batchIdOverlayIndex = 'batchIdOverlayIndex';
static batchIdOverlayIndexPath = ['userId', 'largestBatchId'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should evaluate as part of this PR as this PR changes the schema on disk.

@ehsannas
Copy link
Contributor Author

Addressed comments and fixed merge conflicts. PTAL

@ehsannas ehsannas merged commit 3e9f3e2 into master Feb 12, 2022
@ehsannas ehsannas deleted the ehsann/port-overlays-1 branch February 12, 2022 05:34
@ehsannas ehsannas mentioned this pull request Feb 18, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

@wu-hui wu-hui Awaiting requested review from wu-hui

@dconeybe dconeybe Awaiting requested review from dconeybe

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@ehsannas ehsannas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehsannas @google-oss-bot @schmidt-sebastian