Skip to content

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Jul 7, 2022

Fix incorrect Node ESM exports paths for firestore/lite. They should match https://github.com/firebase/firebase-js-sdk/blob/master/packages/firestore/lite/package.json

Made a mistake in #6321

Fixes #6414

@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2022

🦋 Changeset detected

Latest commit: ac9822c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hsubox76 hsubox76 requested a review from egilmorez as a code owner July 7, 2022 17:31
@hsubox76 hsubox76 requested a review from dwyfrequency July 7, 2022 17:31
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 7, 2022

Size Report 1

Affected Products

  • bundle

    TypeBase (c187446)Merge (fbf686d)Diff
    firestore-lite (Query Cursors)210 kB67.9 kB-142 kB (-67.7%)
    firestore-lite (Query)210 kB71.1 kB-139 kB (-66.2%)
    firestore-lite (Read data once)200 kB55.5 kB-144 kB (-72.2%)
    firestore-lite (Transaction)184 kB80.1 kB-103 kB (-56.4%)
    firestore-lite (Write data)183 kB65.3 kB-118 kB (-64.4%)
  • firebase

    TypeBase (c187446)Merge (fbf686d)Diff
    firebase-firestore-lite.js845 kB267 kB-578 kB (-68.4%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qG2u9K3pbk.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 7, 2022

@google-oss-bot google-oss-bot added the doc-changes PRs that affect docs label Jul 7, 2022
@hsubox76 hsubox76 merged commit ad773fa into master Jul 7, 2022
@hsubox76 hsubox76 deleted the ch-firestore-pkg branch July 7, 2022 18:40
This was referenced Jul 7, 2022
@firebase firebase locked and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

doc-changes PRs that affect docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

package.json exports should include "browser" for @firebase/firestore

3 participants