Skip to content

Update social media platforms #8277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented May 30, 2024

* Google+ expired a while ago
* Twitter was rebranded as X
@jsoref jsoref requested a review from a team as a code owner May 30, 2024 18:49
Copy link

changeset-bot bot commented May 30, 2024

⚠️ No Changeset found

Latest commit: 73ca6c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dlarocque dlarocque linked an issue May 31, 2024 that may be closed by this pull request
@jsoref
Copy link
Contributor Author

jsoref commented May 31, 2024

Fwiw, the reason
Deploy Project Config / Deploy Firebase Project Rules and Functions (pull_request) Failing after 1m
is because this PR is from a fork and the workflow runs with pull_request which doesn't have access to secrets.

For more information, you can see:
https://github.com/orgs/community/discussions/50161#discussioncomment-5833098

#8275 would fix it.


The reason,
Update API reports / Update API reports (pull_request) Failing after 29s
is because the workflow is broken for forks:

ref: ${{ github.event.pull_request.head.ref }}

b35ab8e should fix it.

@dlarocque dlarocque merged commit 3df57ed into firebase:master May 31, 2024
28 of 30 checks passed
@jsoref jsoref deleted the contributing-social-media branch May 31, 2024 19:28
@firebase firebase locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributing guidelines are stale
2 participants