Skip to content

FirebaseServerAppImpl: guard use of FinalizationRegistry based on its availability. #8335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/clever-dryers-double.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@firebase/app': patch
'firebase': patch
---

Guard the use of `FinalizationRegistry` in `FirebaseServerApp` initialization based on the availability of `FinalizationRegistry` in the runtime.
13 changes: 8 additions & 5 deletions packages/app/src/firebaseServerApp.ts
Original file line number Diff line number Diff line change
@@ -32,7 +32,7 @@ export class FirebaseServerAppImpl
implements FirebaseServerApp
{
private readonly _serverConfig: FirebaseServerAppSettings;
private _finalizationRegistry: FinalizationRegistry<object>;
private _finalizationRegistry: FinalizationRegistry<object> | null;
private _refCount: number;

constructor(
@@ -67,9 +67,12 @@ export class FirebaseServerAppImpl
...serverConfig
};

this._finalizationRegistry = new FinalizationRegistry(() => {
this.automaticCleanup();
});
this._finalizationRegistry = null;
if (typeof FinalizationRegistry !== 'undefined') {
this._finalizationRegistry = new FinalizationRegistry(() => {
this.automaticCleanup();
});
}

this._refCount = 0;
this.incRefCount(this._serverConfig.releaseOnDeref);
@@ -97,7 +100,7 @@ export class FirebaseServerAppImpl
return;
}
this._refCount++;
if (obj !== undefined) {
if (obj !== undefined && this._finalizationRegistry !== null) {
this._finalizationRegistry.register(obj, this);
}
}