Skip to content

Spelling fixes #8348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Spelling fixes #8348

wants to merge 5 commits into from

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Jul 3, 2024

Discussion

Fix numerous misspellings in the repo based on a user-submitted spell check GitHub issue. Fixes #8279.

Note: I've fixed the misspellings. The user also provided some suggestions on working changes (ie: existing->preexisting). While I have fixed the code based on most suggestions, I haven't fixed 100% of them. Many would require either API change or a substantial amount of work on internal code. Some code hasn't been changed in a long time and I fear cracking it open. I prioritized changes pertaining to user-facing documentation instead.

Testing

CI.

API Changes

N/A.

Copy link

changeset-bot bot commented Jul 3, 2024

🦋 Changeset detected

Latest commit: 0763f9d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@firebase/installations-types Patch
@firebase/performance-compat Patch
@firebase/rules-unit-testing Patch
@firebase/performance-types Patch
@firebase/firestore-compat Patch
@firebase/database-compat Patch
@firebase/storage-compat Patch
@firebase/remote-config Patch
@firebase/auth-compat Patch
@firebase/performance Patch
@firebase/app-compat Patch
@firebase/analytics Patch
@firebase/app-check Patch
@firebase/component Patch
@firebase/firestore Patch
@firebase/functions Patch
@firebase/database Patch
firebase Patch
@firebase/vertexai-preview Patch
@firebase/storage Patch
@firebase/auth Patch
@firebase/util Patch
@firebase/app Patch
@firebase/installations-compat Patch
@firebase/remote-config-compat Patch
@firebase/analytics-compat Patch
@firebase/app-check-compat Patch
@firebase/functions-compat Patch
@firebase/messaging-compat Patch
@firebase/installations Patch
@firebase/messaging Patch
@firebase/database-types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 3, 2024

Size Report 1

Affected Products

  • @firebase/analytics

    TypeBase (766a53e)Merge (5124e9e)Diff
    browser21.8 kB21.8 kB+1 B (+0.0%)
    esm527.0 kB27.0 kB+1 B (+0.0%)
    main28.4 kB28.4 kB+1 B (+0.0%)
    module21.8 kB21.8 kB+1 B (+0.0%)
  • @firebase/auth

    TypeBase (766a53e)Merge (5124e9e)Diff
    browser182 kB182 kB+2 B (+0.0%)
    cordova210 kB210 kB+6 B (+0.0%)
    esm5236 kB236 kB+2 B (+0.0%)
    main179 kB179 kB+2 B (+0.0%)
    module182 kB182 kB+2 B (+0.0%)
    react-native199 kB199 kB+2 B (+0.0%)
  • @firebase/auth-compat

    TypeBase (766a53e)Merge (5124e9e)Diff
    browser20.2 kB20.2 kB+1 B (+0.0%)
    esm527.1 kB27.1 kB+1 B (+0.0%)
    main29.5 kB29.5 kB+1 B (+0.0%)
    module20.2 kB20.2 kB+1 B (+0.0%)
  • @firebase/auth-cordova

    TypeBase (766a53e)Merge (5124e9e)Diff
    browser210 kB210 kB+6 B (+0.0%)
    module210 kB210 kB+6 B (+0.0%)
  • @firebase/auth-web-extension

    TypeBase (766a53e)Merge (5124e9e)Diff
    browser137 kB137 kB+2 B (+0.0%)
    main152 kB152 kB+2 B (+0.0%)
    module137 kB137 kB+2 B (+0.0%)
  • @firebase/auth/internal

    TypeBase (766a53e)Merge (5124e9e)Diff
    browser193 kB193 kB+6 B (+0.0%)
    esm5250 kB250 kB+6 B (+0.0%)
    main215 kB215 kB+6 B (+0.0%)
    module193 kB193 kB+6 B (+0.0%)
  • @firebase/firestore

    TypeBase (766a53e)Merge (5124e9e)Diff
    main582 kB582 kB+3 B (+0.0%)
  • @firebase/messaging

    TypeBase (766a53e)Merge (5124e9e)Diff
    browser21.3 kB21.3 kB+1 B (+0.0%)
    esm526.8 kB26.8 kB+1 B (+0.0%)
    main27.4 kB27.4 kB+1 B (+0.0%)
    module21.3 kB21.3 kB+1 B (+0.0%)
  • @firebase/messaging-compat

    TypeBase (766a53e)Merge (5124e9e)Diff
    browser2.08 kB2.08 kB+1 B (+0.0%)
    esm52.51 kB2.51 kB+1 B (+0.0%)
    main2.90 kB2.90 kB+1 B (+0.0%)
    module2.08 kB2.08 kB+1 B (+0.0%)
  • @firebase/rules-unit-testing

    TypeBase (766a53e)Merge (5124e9e)Diff
    main17.8 kB17.8 kB+1 B (+0.0%)
  • bundle

    TypeBase (766a53e)Merge (5124e9e)Diff
    analytics (logEvent)44.5 kB44.5 kB+1 B (+0.0%)
    messaging (send + receive)46.9 kB46.9 kB+1 B (+0.0%)
  • firebase

    TypeBase (766a53e)Merge (5124e9e)Diff
    firebase-analytics-compat.js26.5 kB26.5 kB+1 B (+0.0%)
    firebase-analytics.js29.7 kB29.7 kB+1 B (+0.0%)
    firebase-auth-compat.js140 kB140 kB+7 B (+0.0%)
    firebase-auth-cordova.js177 kB177 kB+6 B (+0.0%)
    firebase-auth-web-extension.js117 kB117 kB+2 B (+0.0%)
    firebase-auth.js151 kB151 kB+2 B (+0.0%)
    firebase-compat.js786 kB786 kB+10 B (+0.0%)
    firebase-messaging-compat.js38.4 kB38.4 kB+2 B (+0.0%)
    firebase-messaging.js28.7 kB28.7 kB+2 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/x6L8efqqbQ.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 3, 2024

Size Analysis Report 1

Affected Products

  • @firebase/analytics

    • getAnalytics

      Size

      TypeBase (766a53e)Merge (5124e9e)Diff
      size10.6 kB10.6 kB+1 B (+0.0%)
      size-with-ext-deps44.4 kB44.4 kB+1 B (+0.0%)
    • getGoogleAnalyticsClientId

      Size

      TypeBase (766a53e)Merge (5124e9e)Diff
      size10.5 kB10.5 kB+1 B (+0.0%)
      size-with-ext-deps37.2 kB37.2 kB+1 B (+0.0%)
    • initializeAnalytics

      Size

      TypeBase (766a53e)Merge (5124e9e)Diff
      size10.5 kB10.5 kB+1 B (+0.0%)
      size-with-ext-deps37.5 kB37.5 kB+1 B (+0.0%)
    • isSupported

      Size

      TypeBase (766a53e)Merge (5124e9e)Diff
      size10.4 kB10.4 kB+1 B (+0.0%)
      size-with-ext-deps37.1 kB37.1 kB+1 B (+0.0%)
    • logEvent

      Size

      TypeBase (766a53e)Merge (5124e9e)Diff
      size10.2 kB10.2 kB+1 B (+0.0%)
      size-with-ext-deps37.0 kB37.0 kB+1 B (+0.0%)
    • setAnalyticsCollectionEnabled

      Size

      TypeBase (766a53e)Merge (5124e9e)Diff
      size10.4 kB10.4 kB+1 B (+0.0%)
      size-with-ext-deps37.1 kB37.1 kB+1 B (+0.0%)
    • setConsent

      Size

      TypeBase (766a53e)Merge (5124e9e)Diff
      size10.4 kB10.4 kB+1 B (+0.0%)
      size-with-ext-deps37.1 kB37.1 kB+1 B (+0.0%)
    • setCurrentScreen

      Size

      TypeBase (766a53e)Merge (5124e9e)Diff
      size10.5 kB10.5 kB+1 B (+0.0%)
      size-with-ext-deps37.2 kB37.2 kB+1 B (+0.0%)
    • setDefaultEventParameters

      Size

      TypeBase (766a53e)Merge (5124e9e)Diff
      size10.4 kB10.4 kB+1 B (+0.0%)
      size-with-ext-deps37.1 kB37.1 kB+1 B (+0.0%)
    • setUserId

      Size

      TypeBase (766a53e)Merge (5124e9e)Diff
      size10.5 kB10.5 kB+1 B (+0.0%)
      size-with-ext-deps37.2 kB37.2 kB+1 B (+0.0%)
    • setUserProperties

      Size

      TypeBase (766a53e)Merge (5124e9e)Diff
      size10.5 kB10.5 kB+1 B (+0.0%)
      size-with-ext-deps37.3 kB37.3 kB+1 B (+0.0%)
    • settings

      Size

      TypeBase (766a53e)Merge (5124e9e)Diff
      size10.4 kB10.4 kB+1 B (+0.0%)
      size-with-ext-deps37.1 kB37.1 kB+1 B (+0.0%)
  • @firebase/auth

    • debugErrorMap

      Size

      TypeBase (766a53e)Merge (5124e9e)Diff
      size51.4 kB51.4 kB+2 B (+0.0%)
      size-with-ext-deps72.9 kB72.9 kB+2 B (+0.0%)
  • @firebase/messaging

    • deleteToken

      Size

      TypeBase (766a53e)Merge (5124e9e)Diff
      size12.7 kB12.7 kB+1 B (+0.0%)
      size-with-ext-deps39.3 kB39.3 kB+1 B (+0.0%)
    • getMessaging

      Size

      TypeBase (766a53e)Merge (5124e9e)Diff
      size12.8 kB12.8 kB+1 B (+0.0%)
      size-with-ext-deps46.5 kB46.5 kB+1 B (+0.0%)
    • getToken

      Size

      TypeBase (766a53e)Merge (5124e9e)Diff
      size12.2 kB12.2 kB+1 B (+0.0%)
      size-with-ext-deps38.8 kB38.8 kB+1 B (+0.0%)
    • isSupported

      Size

      TypeBase (766a53e)Merge (5124e9e)Diff
      size12.6 kB12.6 kB+1 B (+0.0%)
      size-with-ext-deps39.2 kB39.2 kB+1 B (+0.0%)
    • onMessage

      Size

      TypeBase (766a53e)Merge (5124e9e)Diff
      size12.4 kB12.4 kB+1 B (+0.0%)
      size-with-ext-deps39.0 kB39.0 kB+1 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0A7lEoCcLK.html

@@ -248,3 +246,4 @@ function getApplicationInfo(firebaseApp: FirebaseApp): ApplicationInfo {
application_process_state: 0
};
}
/* eslint-enable camelcase */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out this entire file requires camelcase to be disabled (now that it's spelled correctly).

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Changeset File Check ⚠️

  • Warning: This PR modifies files in the following packages but they have not been included in the changeset file:%0A - @firebase/app-check-compat%0A - @firebase/installations%0A - @firebase/template%0A%0A Make sure this was intentional.

@DellaBitta DellaBitta marked this pull request as ready for review July 15, 2024 19:09
@DellaBitta DellaBitta changed the title Spell check pass Spelling fixes Jul 15, 2024
@DellaBitta DellaBitta closed this Jul 15, 2024
@firebase firebase locked and limited conversation to collaborators Aug 15, 2024
@DellaBitta DellaBitta deleted the ddb-doc-misspellings branch January 24, 2025 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firebase-js-sdk has typos
2 participants