Skip to content

Upgrade two more download-artifact v3 actions to v4 in Firestore workflow #8706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Upgrade two more download-artifact v3 actions to v4 in Firestore workflow #8706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
915a81f
Upgraded last download-artifact v3 actions
DellaBitta Jan 14, 2025
5344133
touch karma.base.js
DellaBitta Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test-changed-firestore.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ jobs:
with:
node-version: 22.10.0
- name: Download build archive
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: build.tar.gz
- name: Unzip build artifact
Expand All @@ -259,7 +259,7 @@ jobs:
if: ${{ needs.build.outputs.changed == 'true'}}
steps:
- name: Download build archive
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: build.tar.gz
- name: Unzip build artifact
Expand Down
4 changes: 2 additions & 2 deletions config/karma.base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ const config = {
// Doing 65 seconds to allow for the 20 second firestore tests
browserNoActivityTimeout: 65000,

// preprocess matching files before serving them to the browser
// available preprocessors:
// Preprocess matching files before serving them to the browser.
// Available preprocessors:
// https://npmjs.org/browse/keyword/karma-preprocessor
preprocessors: {
'test/**/*.ts': ['webpack', 'sourcemap'],
Expand Down
Loading