Skip to content

Roll back #8999 #9007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025
Merged

Roll back #8999 #9007

merged 2 commits into from
May 7, 2025

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented May 7, 2025

Reverting #8999. The backend isn't ready to accept the Vertex header that would be sent by defaulting this var to true. It should be ready by the I/O release next week.

Copy link

changeset-bot bot commented May 7, 2025

🦋 Changeset detected

Latest commit: 324a7af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@firebase/app-compat Patch
@firebase/app-check Patch
@firebase/app Patch
@firebase/app-check-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review May 7, 2025 22:14
@hsubox76 hsubox76 requested review from a team as code owners May 7, 2025 22:14
Copy link
Contributor

github-actions bot commented May 7, 2025

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v13.0

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (d5428f3)Merge (6088ff9)Diff
    browser19.5 kB19.5 kB+3 B (+0.0%)
    main20.4 kB20.4 kB+3 B (+0.0%)
    module19.5 kB19.5 kB+3 B (+0.0%)
  • @firebase/app-check

    TypeBase (d5428f3)Merge (6088ff9)Diff
    browser26.9 kB26.7 kB-210 B (-0.8%)
    main27.9 kB27.7 kB-210 B (-0.8%)
    module26.9 kB26.7 kB-210 B (-0.8%)
  • @firebase/database-compat/standalone

    TypeBase (d5428f3)Merge (6088ff9)Diff
    main366 kB366 kB+3 B (+0.0%)
  • bundle

    46 size changes

    TypeBase (d5428f3)Merge (6088ff9)Diff
    analytics (logEvent)44.7 kB44.7 kB+1 B (+0.0%)
    app-check (CustomProvider)38.0 kB37.8 kB-203 B (-0.5%)
    app-check (ReCaptchaEnterpriseProvider)40.5 kB40.3 kB-203 B (-0.5%)
    app-check (ReCaptchaV3Provider)40.5 kB40.3 kB-203 B (-0.5%)
    auth (Anonymous)77.8 kB77.8 kB+1 B (+0.0%)
    auth (EmailAndPassword)87.9 kB87.9 kB+1 B (+0.0%)
    auth (GoogleFBTwitterGitHubPopup)105 kB105 kB+1 B (+0.0%)
    auth (GooglePopup)102 kB102 kB+1 B (+0.0%)
    auth (GoogleRedirect)102 kB102 kB+1 B (+0.0%)
    auth (Phone)95.3 kB95.3 kB+1 B (+0.0%)
    database (Append to a list of data)150 kB150 kB+1 B (+0.0%)
    database (Filtering data)149 kB149 kB+1 B (+0.0%)
    database (Listen for child events)165 kB165 kB+1 B (+0.0%)
    database (Listen for value events + Detach listeners)165 kB165 kB+1 B (+0.0%)
    database (Listen for value events)165 kB165 kB+1 B (+0.0%)
    database (Read data once)165 kB165 kB+1 B (+0.0%)
    database (Save data as transactions)167 kB167 kB+1 B (+0.0%)
    database (Sort data)151 kB151 kB+1 B (+0.0%)
    database (Write data)149 kB149 kB+1 B (+0.0%)
    firestore (CSI Auto Indexing Disable and Delete)275 kB275 kB+1 B (+0.0%)
    firestore (CSI Auto Indexing Enable)275 kB275 kB+1 B (+0.0%)
    firestore (Persistence)306 kB306 kB+1 B (+0.0%)
    firestore (Query Cursors)252 kB252 kB+1 B (+0.0%)
    firestore (Query)249 kB249 kB+1 B (+0.0%)
    firestore (Read data once)237 kB237 kB+1 B (+0.0%)
    firestore (Read Write w Persistence)331 kB331 kB+1 B (+0.0%)
    firestore (Realtime updates)239 kB239 kB+1 B (+0.0%)
    firestore (Transaction)216 kB216 kB+1 B (+0.0%)
    firestore (Write data)216 kB216 kB+1 B (+0.0%)
    firestore-lite (Query Cursors)105 kB105 kB+1 B (+0.0%)
    firestore-lite (Query)101 kB101 kB+1 B (+0.0%)
    firestore-lite (Read data once)76.3 kB76.3 kB+1 B (+0.0%)
    firestore-lite (Transaction)102 kB102 kB+1 B (+0.0%)
    firestore-lite (Write data)85.9 kB85.9 kB+1 B (+0.0%)
    functions (call)35.0 kB35.0 kB+1 B (+0.0%)
    messaging (send + receive)47.5 kB47.5 kB+1 B (+0.0%)
    performance (trace)62.4 kB62.4 kB+1 B (+0.0%)
    remote-config (getAndFetch)48.8 kB48.8 kB+1 B (+0.0%)
    storage (getBytes)42.8 kB42.8 kB+1 B (+0.0%)
    storage (getDownloadURL)44.9 kB44.9 kB+1 B (+0.0%)
    storage (getMetadata)44.3 kB44.3 kB+1 B (+0.0%)
    storage (list + listAll)43.8 kB43.8 kB+1 B (+0.0%)
    storage (updateMetadata)44.6 kB44.6 kB+1 B (+0.0%)
    storage (uploadBytes)49.5 kB49.5 kB+1 B (+0.0%)
    storage (uploadBytesResumable)59.4 kB59.4 kB+1 B (+0.0%)
    storage (uploadString)49.7 kB49.7 kB+1 B (+0.0%)

  • firebase

    TypeBase (d5428f3)Merge (6088ff9)Diff
    firebase-app-check-compat.js23.1 kB22.9 kB-197 B (-0.9%)
    firebase-app-check.js25.5 kB25.3 kB-194 B (-0.8%)
    firebase-app.js103 kB103 kB+3 B (+0.0%)
    firebase-compat.js798 kB797 kB-198 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/VBLoKRZihS.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

  • @firebase/analytics

    • getAnalytics

      Size

      TypeBase (d5428f3)Merge (6088ff9)Diff
      size-with-ext-deps44.6 kB44.6 kB+1 B (+0.0%)
  • @firebase/app

    • getApp

      Size

      TypeBase (d5428f3)Merge (6088ff9)Diff
      size10.2 kB10.2 kB+1 B (+0.0%)
      size-with-ext-deps25.2 kB25.2 kB+1 B (+0.0%)
    • initializeApp

      Size

      TypeBase (d5428f3)Merge (6088ff9)Diff
      size10.1 kB10.1 kB+1 B (+0.0%)
      size-with-ext-deps25.1 kB25.1 kB+1 B (+0.0%)
    • initializeServerApp

      Size

      TypeBase (d5428f3)Merge (6088ff9)Diff
      size12.3 kB12.3 kB+2 B (+0.0%)
      size-with-ext-deps26.3 kB26.3 kB+2 B (+0.0%)
  • @firebase/app-check

    • initializeAppCheck

      Size

      TypeBase (d5428f3)Merge (6088ff9)Diff
      size11.7 kB11.5 kB-203 B (-1.7%)
      size-with-ext-deps37.0 kB36.8 kB-203 B (-0.5%)
  • @firebase/auth

    • getAuth

      Size

      TypeBase (d5428f3)Merge (6088ff9)Diff
      size-with-ext-deps104 kB104 kB+1 B (+0.0%)
  • @firebase/data-connect

    • getDataConnect

      Size

      TypeBase (d5428f3)Merge (6088ff9)Diff
      size-with-ext-deps38.8 kB38.8 kB+1 B (+0.0%)
    • subscribe

      Size

      TypeBase (d5428f3)Merge (6088ff9)Diff
      size-with-ext-deps39.3 kB39.3 kB+1 B (+0.0%)
    • toQueryRef

      Size

      TypeBase (d5428f3)Merge (6088ff9)Diff
      size-with-ext-deps39.0 kB39.0 kB+1 B (+0.0%)
    • validateArgs

      Size

      TypeBase (d5428f3)Merge (6088ff9)Diff
      size-with-ext-deps38.9 kB38.9 kB+1 B (+0.0%)
  • @firebase/database

    • getDatabase

      Size

      TypeBase (d5428f3)Merge (6088ff9)Diff
      size-with-ext-deps148 kB148 kB+1 B (+0.0%)
  • @firebase/firestore

    • getFirestore

      Size

      TypeBase (d5428f3)Merge (6088ff9)Diff
      size-with-ext-deps96.5 kB96.5 kB+1 B (+0.0%)
  • @firebase/functions

    • getFunctions

      Size

      TypeBase (d5428f3)Merge (6088ff9)Diff
      size-with-ext-deps28.8 kB28.8 kB+1 B (+0.0%)
  • @firebase/installations

    • getInstallations

      Size

      TypeBase (d5428f3)Merge (6088ff9)Diff
      size-with-ext-deps34.0 kB34.0 kB+1 B (+0.0%)
  • @firebase/messaging

    • getMessaging

      Size

      TypeBase (d5428f3)Merge (6088ff9)Diff
      size-with-ext-deps47.2 kB47.2 kB+1 B (+0.0%)
  • @firebase/performance

    • getPerformance

      Size

      TypeBase (d5428f3)Merge (6088ff9)Diff
      size-with-ext-deps62.3 kB62.3 kB+1 B (+0.0%)
  • @firebase/remote-config

    • getRemoteConfig

      Size

      TypeBase (d5428f3)Merge (6088ff9)Diff
      size-with-ext-deps46.6 kB46.6 kB+1 B (+0.0%)
  • @firebase/storage

    • getStorage

      Size

      TypeBase (d5428f3)Merge (6088ff9)Diff
      size-with-ext-deps38.4 kB38.4 kB+1 B (+0.0%)
  • @firebase/vertexai

    • getVertexAI

      Size

      TypeBase (d5428f3)Merge (6088ff9)Diff
      size-with-ext-deps28.8 kB28.8 kB+1 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/UsXWUxc18T.html

@hsubox76 hsubox76 merged commit 51e7b48 into main May 7, 2025
60 of 69 checks passed
@hsubox76 hsubox76 deleted the ch-rollback branch May 7, 2025 22:51
@google-oss-bot google-oss-bot mentioned this pull request May 7, 2025
hsubox76 added a commit that referenced this pull request May 8, 2025
This reverts commit 51e7b48.
@hsubox76 hsubox76 mentioned this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants