-
Notifications
You must be signed in to change notification settings - Fork 948
change(firestore): close Firestore instance more gracefully when "Clear Site Data" button pressed in browser #9118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dconeybe
wants to merge
5
commits into
main
Choose a base branch
from
dconeybe/ClearSiteDataTerminateFirestore
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce() from another tab.
🦋 Changeset detectedLatest commit: 51a279d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (207,898 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the 2nd in a chain of PRs (previous PR: #9087) that unify the logic that handles unexpected IndexedDB database deletion.
This PR enhances the robustness and user experience when the Firestore SDK's IndexedDB database is unexpectedly deleted, such as by a user clicking 'Clear Site Data' in their browser or another tab clearing persistence. It introduces a more granular event system for database deletion notifications, enabling the SDK to provide more informative error messages and ensure a more graceful termination process.
Highlights
ClearSiteDataDatabaseDeletedEvent
,VersionChangeDatabaseDeletedEvent
) to differentiate between various IndexedDB database deletion scenarios, providing more context to theDatabaseDeletedListener
.setDatabaseDeletedListener
to receive detailed event information, allowing for more specific logging and error handling during Firestore termination.FirestoreError
of typefailed-precondition
is now thrown. This error provides a clear message to the user about potential IndexedDB corruption and suggests a page reload, and is thrown after attempting to terminate Firestore.SimpleDb.open()
to defer handling of 'Clear Site Data' detection from theonupgradeneeded
event to theonsuccess
event. This change prevents generic errors and allows for more precise and actionable error reporting to thedatabaseDeletedListener
.