Update Fireperf logging to use sendBeacon only if the payload is under the 64KB limit #9120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r the 64KB limit for most browsers. - For the flush, attempt to use sendBeacon with a low number of events incase sendBeacon is also used by other libraries.
🦋 Changeset detectedLatest commit: 74db5f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Changeset File Check ✅
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
raymondlam
changed the title
raymondlam
force-pushed
the
raymondlam/perffix
branch
from
6f57725 to
74db5f8
Compare
visumickey
approved these changes
Jun 25, 2025
| @@ -88,7 +89,7 @@ describe('Firebase Performance > transport_service', () => { | |||
| expect(fetchStub).to.not.have.been.called; | |||
| }); | |||
|
|
|||
| it('sends up to the maximum event limit in one request', async () => { | |||
| it('sends up to the maximum event limit in one request if payload is under 64 KB', async () => { | |||
There was a problem hiding this comment.
How are we ensuring that the payload is less than 64KB in this test? Is this based on the size of the events?
| }) | ||
| ); | ||
|
|
||
| const payload = 'a'.repeat(300); |
There was a problem hiding this comment.
Just a nit pick. Is there a way we cna turn the payload to be a factor of may be 512B so that we dispatch 128+ events to achieve the 64KB+ situation? That way it would be easier to understad what is happening in the test. Currently, it is cryptic.
| const MAX_SEND_BEACON_PAYLOAD_SIZE = 65536; | ||
| // The max number of events to send during a flush. This number is kept low to since Chrome has a | ||
| // shared payload limit for all sendBeacon calls in the same nav context. | ||
| const MAX_FLUSH_SIZE = 40; |
There was a problem hiding this comment.
How did we arrive at this 40? Is this heuristic driven or are we making it as a random pick. If a random pick, should we make it Remote COnfig configurable with default value of 40?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #9067
From this comment,
Edge and Firefox enforce a 64KB limit per beacon. Chrome enforces a 64KB quota across all beacon-initiated requests within same nav context.Since Chrome enforces a limit across all beacon requests, we'll attempt to use sendBeacon with a low number of events incase sendBeacon is also used by other libraries.