Skip to content

fix(externs): fix window var provided extern #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2017
Merged

Conversation

jshcrowthe
Copy link
Contributor

Removes the window.atob function extern provided by the browser natively.

Copy link
Contributor

@bojeil-google bojeil-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this used anywhere? atob is not supported in IE 9.

@jshcrowthe
Copy link
Contributor Author

AFAIK, this is used in storage and if available in database.

@jshcrowthe jshcrowthe merged commit 58fc4c9 into master Jul 7, 2017
@jshcrowthe jshcrowthe deleted the externs-fix branch July 7, 2017 22:21
@firebase firebase locked and limited conversation to collaborators Oct 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants