firebase deploy --only functions run successfully without deploy any function if run within yarn workspace (Already nohoist every dependency).

[TrustyTechSG]

[REQUIRED] Environment info

**firebase-tools:**11.15.0

Platform: MacOS 13.0

[REQUIRED] Test case

index.js

import functions from "firebase-functions";

export const hello = functions.https.onRequest((request, response) => {
  response.send("Hello from Firebase!");
});

package.json

{
  "name": "test",
  "version": "1.0.0",
  "main": "index.js",
  "license": "MIT",
  "private": true,
  "sideEffects": false,
  "mode": "production",
  "type": "module",
  "scripts": {
    "start": "npm run shell"
  },
  "dependencies": {
    "firebase-functions": "^4.0.1"
  },
  "engines": {
    "node": "16"
  }
}

firebase.json

{
  "functions": [
    {
      "source": "/",
      "codebase": "test"
    }
  ]
}

[REQUIRED] Steps to reproduce

1. Put the above package.json, index.js and firebase.json into test folder under a simple yarn workspace
   /root
   /packages/test
   /package.json (worksapce package.json)

{
  "name": "testing",
  "private": true,
  "workspaces": {
    "packages": [
      "packages/*"
    ],
    "nohoist": [
      "**/firebase-admin",
      "**/firebase-admin/**",
      "**/firebase-functions",
      "**/firebase-functions/**"
    ]
  },
}

2. Run yarn, and cd to packages/test to verify all dependency are installed locally (within the same folder)
3. Run firebase deploy --only functions.

[REQUIRED] Expected behavior

Function hello been successfully created.

[REQUIRED] Actual behavior

deploy command run successfully without error, but no function deployed.

Now, simply copy the packages/test folder to anywhere outside the workspace root and cd to the new folder immediately run: firebase deploy --only functions. Function hello successfully deployed.

[inlined]

We've recently discovered a bug with the 4.0 SDK and workspaces. We have a temporary fix coming out very soon that will unlock the functionality of older SDKs, but some V2 functions require a deeper fix. Stay tuned.

[TrustyTechSG]

Thank you for the reply @inlined, just asking is this update also going to support deploy function with unpublished local workspace dependency? currently I notice the deploy process assume all dependencies are publish available, which is not true for workspace use case, we have many unpublished dependencies.

[taeold]

Same bug, reported on #5517. Noted here for cross-tracking.

[taeold]

Also similar bug in #5145.

[taeold]

We reverted back the change that broke many users in v4.0.2 of the firebase functions sdk.

We are working on a long term solution to make the function deployment aware of workspaces and other dev toolings that changes where npm packages are installed (e.g. pnpm).

In the meantime, please give 4.0.2 a try. Would appreciate your feedbacks.

See #5517 for more info.

[joehan]

Closing since I beleive #5215 fixed this.