Adds integration test for CF3 discovery in pnpm workspace project configuration #5329
+61
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 56.31% // Head: 56.32% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5329 +/- ##
=======================================
Coverage 56.31% 56.32%
=======================================
Files 313 313
Lines 21078 21078
Branches 4282 4282
=======================================
+ Hits 11870 11872 +2
+ Misses 8181 8180 -1
+ Partials 1027 1026 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
taeold
approved these changes
Dec 13, 2022
| response.send(msg); | ||
| }); | ||
|
|
||
| console.log(msg); |
There was a problem hiding this comment.
nope. forgot to take that out :|
|
nit* I don't think this change requires a changelog entry since Firebase developers aren't affected by the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix implemented in #5215 enabling CF3 discovery in yarn workspaces actually enables CF3 discovery in pnpm workspaces as well. I add a simple integration test to cover CF3 discovery in pnpm workspaces.