Skip to content

fix: make sure the auth emulator respects multi-tenancy for sso users #8544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 15, 2025

Conversation

wieringen
Copy link
Contributor

Fixes #8541

Copy link

google-cla bot commented May 12, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@wieringen wieringen force-pushed the master branch 2 times, most recently from 63e5244 to 35d3e3b Compare May 13, 2025 06:52
@aalej
Copy link
Contributor

aalej commented May 13, 2025

Thanks for creating this PR! I've tested the changes and verified that the users are now getting created in the correct tenants. Let me try to ask someone from our engineering team to review this.

Could you add a CHANGELOG.md entry for this change?

wieringen added a commit to wieringen/firebase-tools that referenced this pull request May 13, 2025
@wieringen
Copy link
Contributor Author

Done, thanks a lot!

@joehan
Copy link
Contributor

joehan commented May 13, 2025

Looks like you need to fix merge conflicts with the CHANGELOG and then run npm run format, but otherwise this looks good to me! Thanks for the contribution

wieringen added a commit to wieringen/firebase-tools that referenced this pull request May 13, 2025
wieringen added a commit to wieringen/firebase-tools that referenced this pull request May 13, 2025
@wieringen
Copy link
Contributor Author

@joehan done :)

wieringen and others added 3 commits May 15, 2025 09:37
@joehan joehan merged commit 2ad870c into firebase:master May 15, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions May 15, 2025
kjelko pushed a commit that referenced this pull request May 16, 2025
…#8544)

* fix: make sure the auth emulator respects multi-tenancy for sso users

* chore: add changelog entry for #8544

---------

Co-authored-by: joehan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The auth emulator can only create sso users in the default tenant
3 participants