Skip to content

Conversation

sl4m
Copy link
Contributor

@sl4m sl4m commented Jun 21, 2023

Description

Currently, the class fails to compile in versions of Unity below 2023. Wrapping the UNITY_2023_1_OR_NEWER directive around BaseGameActivityClass solves the problem.

Testing

It compiles.

Type of Change

Place an x the applicable box:

  • [ x] Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@google-cla
Copy link

google-cla bot commented Jun 21, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@a-maurice
Copy link
Collaborator

In general this seems fine to me. Just curious, was this a warning as an error type problem (Unused variable)? Cause that's the only issue I can potentially see.

@a-maurice a-maurice merged commit 964c2e2 into firebase:main Jun 21, 2023
@sl4m sl4m deleted the patch-1 branch June 21, 2023 20:22
@sl4m
Copy link
Contributor Author

sl4m commented Jun 21, 2023

@a-maurice It was an error, so we needed to fix it on our end.

@firebase firebase locked and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants