Use google-closure-deps instead of depswriter.py. #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjin
added a commit
to kjin/firebaseui-web
that referenced
this pull request
Apr 26, 2021
kjin
added a commit
to kjin/firebaseui-web
that referenced
this pull request
Apr 26, 2021
The latter is deprecated and will be deleted soon.
bojeil-google
approved these changes
Apr 27, 2021
There was a problem hiding this comment.
Thanks for the fix @kjin. While, testing your change, I discovered some broken tests unrelated to this PR. I will merge this and follow up with the fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Closure Library, we will be removing
depswriter.pyand other Python-based build scripts soon.depswriter.pyis superceded bygoogle-closure-deps, a similar tool we maintain that is implemented in Node.js.Here, I've substituted the
depswriter.pycommand with a corresponding command fromgoogle-closure-deps; the CLI flags are similar. The difference in output is minimal (see below).Explanation of "extra" flags:
--closure-path="node_modules/google-closure-library/closure/goog"Path to Closure (now required)--file="node_modules/google-closure-library/closure/goog/deps.js"Use the deps.js file bundled with Closure as part of deps calculation--exclude=...Not strictly necessary, but prevents these files from being written todeps.jsas trivial, 0-dependency entriesFor reference, the diff of the resulting
deps.jsfrom runningnpm run generate-test-files(with lines sorted and formatted for diff clarity) is here.