-
Notifications
You must be signed in to change notification settings - Fork 4k
🐛 [firebase_dynamic_links] GoRouter redirect does not work on iOS #10346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the report @bstolinski |
Hi @darshankawar, if I understand the author of this correctly then he wants the opposite effect to mine - version 3.0.9+ should solve his problem on iOS (not sure about Android). Back to my problem, in my app I don't use the firebase_dynamic_links So my question is whether it is possible to add an option whether dynamic links are to be handled only by firebase_dynamic_links (current 3.0.9+ behaviour) or by other libraries as well. |
I am trying to wrap my head around this, but still not completely sure about it. I think other libraries too should handle the dynamic links. See this issue and check if it helps in your case. |
It was working before this change (one line of code) so I don't understand why you are sending a link to an issue that is not related to this at all. Is my problem unclear to you? Should I try to describe it better? |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as outdated.
This comment was marked as outdated.
I get the same issue. When debugging, the goRouter prints out "going to /?link= ..." the entire dynamic link, which indicates to me that the dynamic links library is not parsing the dynamic link correctly. It works just fine on Android. Although I can't seem to get it working on any 5.* version. I do notice that if I click the link and it brings me to the "Open link in app?" page and I hit open I get this non-functional behavior, but if I long hold the open button to open in browser then it brings me to a "Failed to resolve uri domain" and lists the whitelisted URL with the attached route. Sometimes a smart banner "Open in app" appears and when I hit that it works as expected For example, in my situation, my whitelisted domain is link.turfsports.co (regex preview is ^https{0,1}://link.turfsports.co([/#?].*){0,1}$) and the failed Uri domain prefix is https://link.turfsports.co/mypage/myvar |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@darshankawar still an on going issue.
I really must ask why was this closed? |
Thanks for the update. The bot didn't seem to remove the |
@TomBeckett |
Coming back to this issue, I tried to replicate using the details mentioned in original post #10346 (comment), but couldn't properly replicate it. Maybe I missed some steps to properly come up with a code sample, but will keep this issue open for team's attention. |
@bstolinski @TomBeckett - Could you provide a code sample, please? I'll take a look at this. Thanks. |
@russellwheatley yes, I will do it in the coming days |
@russellwheatley here is the code with examples. Please note that for Android versions 5.0.8 and 5.1.1 behave identically, the difference is only visible on iOS. From what I have observed this change is responsible for it working differently. firebase_dynamic_links 5.0.8 repo branchandroid_5.0.8.movios_5.0.8.movfirebase_dynamic_links 5.1.1 repo branchandroid_5.1.1.movios_5.1.1.mov |
@darshankawar any updates? |
Hi folks, we'd like to inform you that the Firebase Dynamic Links service will be shutdown on August 25, 2025. In the meantime, only critical or security issues will be fixed in the SDK. |
Bug report
Describe the bug
Changes in version 5.0.9 #10100 have broken GoRouter's deep link capture on iOS. This only applies to Firebase Dynamic Links, other custom deep links works correctly. It opens the app, but that's it. In version 5.0.8 everything worked fine. In version 5.0.9+ it only works on Android. I know firebase_dynamic_links has its own methods for this but maybe it would be possible to look at and fix this. This may be related to:
#10340
#10336
#10262
Steps to reproduce
Steps to reproduce the behavior:
Flutter doctor
Run
flutter doctor
and paste the output below:Click To Expand
Flutter dependencies
Run
flutter pub deps -- --style=compact
and paste the output below:Click To Expand
The text was updated successfully, but these errors were encountered: