🐛 [cloud_firestore] CollectionReferenceWeb uses implements instead of extends, makes CollectionReferencePlatform fragile #8095
Description
Bug report
Describe the bug
QueryPlatform.verifyExtends does not call PlatformInterface.verifyToken if the instance being verified is an instance of CollectionReferencePlatform. Instead it could call either QueryPlatform.verifyExtends or CollectionReferencePlatform.verifyExtends depending on the type of the instance.
As a result, CollectionReferenceWeb is able to implement CollectionReferencePlatform without extending it.
Steps to reproduce
Steps to reproduce the behavior:
- Add a new method to
CollectionReferencePlatformand release as a "minor" update. - Compile error in
CollectionReferenceWeb: method is not implemented.
Expected behavior
When _JsonQuery calls QueryPlatform.verifyExtends on a CollectionReferencePlatform instance, the implementation of QueryPlatform.verifyExtends should call PlatformInterface.verifyToken even if _delegate is a CollectionReferencePlatform.
Metadata
Metadata
Assignees
Labels
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Participants
Activity
[-]🐛 [cloud_firestore] QueryPlatform.verifyExtends should not skip instances of CollectionReferencePlatform[/-][+]🐛 [cloud_firestore] CollectionReferenceWeb uses implements instead of extends, makes CollectionReferencePlatform fragile[/+]darshankawar commentedon Feb 17, 2022
/cc @Salakar
FirebasePluginPlatformshould not extendPlatformInterface,verifyExtendsis never called #8945verifytoQueryPlatformand change internalverifyTokenAPI toverify#9711MichaelVerdon commentedon Feb 5, 2025
Hey there, is this issue persisting on the latest version?
google-oss-bot commentedon Feb 14, 2025
Hey @collinjackson. We need more information to resolve this issue but there hasn't been an update in 7 weekdays. I'm marking the issue as stale and if there are no new updates in the next 7 days I will close it automatically.
If you have more information that will help us get to the bottom of this, just add a comment!
google-oss-bot commentedon Feb 25, 2025
Since there haven't been any recent updates here, I am going to close this issue.
@collinjackson if you're still experiencing this problem and want to continue the discussion just leave a comment here and we are happy to re-open this.