Skip to content

🐛 [firebase_dynamic_links] can not get utmParameters from PendingDynamicLinkData #8217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garlicsoft opened this issue Mar 4, 2022 · 1 comment · Fixed by #8232
Closed

🐛 [firebase_dynamic_links] can not get utmParameters from PendingDynamicLinkData #8217

garlicsoft opened this issue Mar 4, 2022 · 1 comment · Fixed by #8232
Labels
plugin: dynamic_links resolution: fixed A fix has been merged or is pending merge from a PR. type: bug Something isn't working

Comments

@garlicsoft
Copy link

garlicsoft commented Mar 4, 2022 •
edited
Loading

Bug report

Describe the bug
can not get utmParameters from PendingDynamicLinkData

Steps to reproduce

Steps to reproduce the behavior:

FirebaseDynamicLinks.instance
.getInitialLink()
.then((dynamicLinkData) {});
I can not get utmParameters from dynamicLinkData.

in android/src/main/java/io/flutter/plugins/firebase/dynamiclinks/Utils.java

for (String key : pendingDynamicLinkData.getUtmParameters().keySet()) {
    utmParameters.put(key, pendingDynamicLinkData.getUtmParameters().get(key).toString());
}
 dynamicLink.put("utmParameters", utmParameters);

can not get any parameters

Expected behavior

  • fix the bug in Utils.java
  • add property utmParameters in PendingDynamicLinkData
@garlicsoft garlicsoft added Needs Attention This issue needs maintainer attention. type: bug Something isn't working labels Mar 4, 2022
@darshankawar darshankawar added triage Issue is currently being triaged. plugin: dynamic_links and removed triage Issue is currently being triaged. Needs Attention This issue needs maintainer attention. labels Mar 4, 2022
@darshankawar
Copy link

/cc @russellwheatley

@russellwheatley russellwheatley mentioned this issue Mar 8, 2022
Merged
10 tasks
@darshankawar darshankawar added the resolution: fixed A fix has been merged or is pending merge from a PR. label Mar 10, 2022
@firebase firebase locked and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
plugin: dynamic_links resolution: fixed A fix has been merged or is pending merge from a PR. type: bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@garlicsoft @darshankawar