Skip to content

chore: Replace FallThroughError with UnsupportedError #10087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

dcharkes
Copy link
Contributor

@dcharkes dcharkes commented Dec 9, 2022

Description

FallThroughError is deprecated and will be removed with Dart 3.0. Since this rolls into g3, it's blocking us landing the removal.

This PR migrates the errors to UnsupportedErrors.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Users should not catch Errors, only Exceptions. As such this is not a breaking change.

@dcharkes dcharkes marked this pull request as ready for review December 9, 2022 15:41
@dcharkes dcharkes changed the title Replace FallThroughError with UnsupportedError chore: Replace FallThroughError with UnsupportedError Dec 9, 2022
@dcharkes
Copy link
Contributor Author

Duplicate of:

Feel free to merge that one and close this one.

@dcharkes
Copy link
Contributor Author

Thanks @Lyokone !

@dcharkes
Copy link
Contributor Author

I don't have merge powers here, so please go ahead and merge it.

@rrousselGit rrousselGit merged commit 0592d02 into firebase:master Dec 12, 2022
@dcharkes
Copy link
Contributor Author

Thanks @rrousselGit !

@dcharkes dcharkes deleted the migrate-fallthrougherror branch December 12, 2022 13:15
@itsjustkevin
Copy link

Hey @dcharkes for a sanity check, does this PR close #10079?

@dcharkes
Copy link
Contributor Author

Yes

@firebase firebase locked and limited conversation to collaborators Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants