Skip to content

Remove @visibleForTesting from FirebaseApp constructor #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 9, 2019
Merged

Remove @visibleForTesting from FirebaseApp constructor #1392

merged 5 commits into from
Nov 9, 2019

Conversation

kroikie
Copy link
Collaborator

@kroikie kroikie commented Nov 8, 2019

Description

Remove @VisibleForTesting annotation from FirebaseApp constructor. This will resolve CI issues while a new FirebaseApp creation strategy is WIP.

@kroikie kroikie requested a review from collinjackson November 8, 2019 22:25
collinjackson
collinjackson approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good. Can you add a TODO to keep track of which apps have been configured and assert that the app has previously been configured or been retrieved using appNamed?

@collinjackson
Copy link
Contributor

Also I think we should remove the const from the constructor since we might want to do runtime checks in the future.

collinjackson
collinjackson approved these changes Nov 9, 2019
View reviewed changes
@kroikie kroikie merged commit 31407be into firebase:master Nov 9, 2019
@kroikie kroikie deleted the firebase-app-fix branch November 9, 2019 17:09
@collinjackson collinjackson mentioned this pull request Nov 11, 2019
Merged
13 tasks
@firebase firebase locked and limited conversation to collaborators Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@collinjackson collinjackson collinjackson approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kroikie @collinjackson @googlebot