Skip to content

[CI] Use available simulator for CI #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2019
Merged

[CI] Use available simulator for CI #1404

merged 1 commit into from
Nov 11, 2019

Conversation

kroikie
Copy link
Collaborator

@kroikie kroikie commented Nov 11, 2019

Description

Current iOS simulator is not available in CI. This PR updates the selected simulator to one that is available in CI.

@kroikie kroikie changed the title Use available simulator for CI [CI] Use available simulator for CI Nov 11, 2019
@collinjackson collinjackson self-requested a review November 11, 2019 21:48
@collinjackson collinjackson removed their assignment Nov 11, 2019
@kroikie kroikie merged commit 16ed623 into firebase:master Nov 11, 2019
@harryterkelsen
Copy link

It seems like this works in this PR because on Cirrus it "auto-upgraded" the Mac OS image to mojave-xcode-10.2-flutter. However, on my PR it didn't auto-upgrade and the iOS tests fail because this simulator isn't there. Perhaps we should use the new image in our cirrus.yml?

@firebase firebase locked and limited conversation to collaborators Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@collinjackson collinjackson collinjackson approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kroikie @harryterkelsen @collinjackson @googlebot