-
Notifications
You must be signed in to change notification settings - Fork 4k
[firebase_core_web] Add initial implementation #1488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[firebase_core_web] Add initial implementation #1488
Conversation
packages/firebase_core/firebase_core_web/lib/src/firebase_js.dart
Outdated
Show resolved
Hide resolved
packages/firebase_core/firebase_core_web/lib/firebase_core_web.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last time I checked, we didn't want people using dart:js
/dart:js_util
directly unless they were in the places where you can't use package:
deps. I think you should port this to using package:js
deps (I suggested a couple of changes, that may help)
You're right. We should prefer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the dummy ios/firebase_core_web.podspec
file in this package so we don't break compilation on IOS?
(There's also scripts similar to flutter/plugins so we might need to exclude the platform_interface from here: https://github.com/FirebaseExtended/flutterfire/blob/master/script/build_all_plugins_app.sh#L15 ?) |
Added a dummy podspec. It looks like |
Merging despite failing tests on stable since web plugins aren't supported on stable. |
Description
This adds web support to
firebase_core_web
.Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?