[Firebase_core] Migrate to AndroidX #159
Closed
+16
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,7 +5,7 @@ buildscript { | |||
| } | |||
|
|
|||
| dependencies { | |||
| classpath 'com.android.tools.build:gradle:3.3.0' | |||
| classpath 'com.android.tools.build:gradle:3.5.0' | |||
There was a problem hiding this comment.
did you mean to modify this file?
| @@ -1,5 +1,6 @@ | |||
| #Mon Sep 16 16:11:29 IST 2019 | |||
There was a problem hiding this comment.
this seems unrelated to the firebase_core change
| ## 0.5.0 | ||
|
|
||
| * Migrate To AndroidX. | ||
| * This is a breaking change and requires manual migration. [Click here for more details](https://flutter.dev/docs/development/packages-and-plugins/androidx-compatibility#how-to-migrate-a-flutter-app-to-androidx) |
There was a problem hiding this comment.
Can you clarify what situations are being improved by this change? I don't think we want to force Flutterfire users to manually migrate their apps.
I'm wondering if landing #39 would be sufficient for your use case.
|
my issue has been resolved, thanks!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate Firebase_core to AndroidX
Related Issues
flutter/flutter#40540
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?