[cloud_functions] Add macOS support #1707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure, will do that. Do you have any idea how we should handle tests for the macOS plugins? |
|
I believe you can write XCTests, but they won't be run on the CI. Is this correct @collinjackson? |
franciscojma86
added
the
blocked: customer-response
cbenhagen
force-pushed
the
cloud_functions_macos
branch
from
6bc4bcf to
4d67686
Compare
|
@franciscojma86 rebased and shared the implementation as proposed. Still missing tests. |
|
XCTests are still not supported for macOS, so as long as the PR passes the integration tests, you should be good to land this |
|
Tests seem to fail for unrelated issues. @franciscojma86 can you restart them for me? |
13 tasks
franciscojma86
approved these changes
Feb 18, 2020
This was referenced Feb 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add macOS support.
Related Issues
#1653
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?