Skip to content

[firebase_auth] support confirmPasswordReset #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2020
Merged

[firebase_auth] support confirmPasswordReset #1753

merged 1 commit into from
Jan 7, 2020

Conversation

lanmonster
Copy link
Contributor

Description

This PR lays the foundation for a future PR to be able to handle the whole password reset flow from within the app.

Related Issues

#1739

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

ditman
ditman reviewed Jan 7, 2020
View reviewed changes
Copy link
Contributor

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Let's wait for @hterkelsen for approval, he wrote most of this package!

harryterkelsen
harryterkelsen approved these changes Jan 7, 2020
View reviewed changes
Copy link

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you have a follow-up PR for adding this to package:firebase_auth? It looks like there is no support for this on Android and iOS, so make sure to document that if you add it to package:firebase_auth.

@ditman
Copy link
Contributor

ditman commented Jan 7, 2020

LGTM. Do you have a follow-up PR for adding this to package:firebase_auth?

@hterkelsen yes, I asked @lanmonster to split this one: https://github.com/FirebaseExtended/flutterfire/pull/1744/files into multiple PRs on Discord.

@harryterkelsen harryterkelsen merged commit 21d1710 into firebase:master Jan 7, 2020
@harryterkelsen
Copy link

Landed and published.

@lanmonster lanmonster deleted the confirm-password-reset-platform-interface branch January 8, 2020 15:52
@bgetsug bgetsug mentioned this pull request Jan 8, 2020
Merged
13 tasks
@firebase firebase locked and limited conversation to collaborators Aug 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ditman ditman ditman left review comments

@harryterkelsen harryterkelsen harryterkelsen approved these changes

@collinjackson collinjackson Awaiting requested review from collinjackson

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lanmonster @ditman @harryterkelsen @googlebot