Skip to content

[firebase_auth] Confirm password reset #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jan 26, 2020

Conversation

lanmonster
Copy link
Contributor

Description

This PR gives the ability to confirm password reset in order to control the entire "forgot password" flow from within an app.

Related Issues

#1739

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@bgetsug
Copy link
Contributor

bgetsug commented Jan 8, 2020

@lanmonster I've got an implementation of confirmPasswordReset for firebase_auth_web (which prompted my submission of #1780). There's really not much to it, if you'd like to add it to this PR, otherwise I'm happy to open a separate one:

packages/firebase_auth/firebase_auth_web/lib/firebase_auth_web.dart:

  Future<void> confirmPasswordReset(
    String app,
    String code,
    String newPassword,
  ) {
    final firebase.Auth auth = _getAuth(app);
    return auth.confirmPasswordReset(code, newPassword);
  }

@lanmonster
Copy link
Contributor Author

@bgetsug happy to include that in my PR, but I think it will have to wait until #1780 lands.

@lanmonster lanmonster changed the title Confirm password reset [firebase_auth] Confirm password reset Jan 10, 2020
@collinjackson
Copy link
Contributor

confirmPasswordReset in #1780 has landed, can you please update this PR to use it?

collinjackson and others added 5 commits January 10, 2020 18:54
* Add macos to CI

* Add lint script
…rebase#1780)

* add 'app' to signature of FirebaseAuthPlatform.confirmPasswordReset

* Update packages/firebase_auth/firebase_auth_platform_interface/CHANGELOG.md

Co-authored-by: Collin Jackson <[email protected]>
@lanmonster
Copy link
Contributor Author

@collinjackson I updated the PR

@collinjackson collinjackson merged commit a36e83c into firebase:master Jan 26, 2020
@firebase firebase locked and limited conversation to collaborators Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants