Skip to content

[firebase_auth_platform_interface] Fix typo in the MethodChannel implementation. #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 11, 2020
Merged

[firebase_auth_platform_interface] Fix typo in the MethodChannel implementation. #1796

merged 4 commits into from
Jan 11, 2020

Conversation

ditman
Copy link
Contributor

@ditman ditman commented Jan 10, 2020 •
edited
Loading

Description

Fixed typo in private method of the MethodChannel implementation of the plugin.

$ flutter test
00:07 +59: All tests passed!

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@ditman ditman requested a review from harryterkelsen January 10, 2020 19:53
@ditman ditman requested a review from cyanglaz January 10, 2020 19:56
collinjackson
collinjackson approved these changes Jan 11, 2020
View reviewed changes
@ditman ditman merged commit 2c8dd75 into firebase:master Jan 11, 2020
@ditman ditman deleted the issues/46045 branch January 11, 2020 02:53
@ditman
Copy link
Contributor Author

ditman commented Jan 11, 2020

Published and tagged.

@firebase firebase locked and limited conversation to collaborators Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@collinjackson collinjackson collinjackson approved these changes

@harryterkelsen harryterkelsen Awaiting requested review from harryterkelsen

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ditman @collinjackson @googlebot