-
Notifications
You must be signed in to change notification settings - Fork 4k
[cloud_functions] Update cloud_functions to use platform interface #1854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…_functions plugin.
…isolate it from following changes.
… interface to be a close reflection of the MethodChannel interface.
…pyright date in LICENSE.
...s/android/src/main/java/io/flutter/plugins/firebase/cloudfunctions/CloudFunctionsPlugin.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits
@sbeitzel could you give me a quick rundown on/if there's anything to do for the following issue I had when upgrading to this version (this is on an iOS simulator): I haven't dug too deeply, and just downgraded for now as I have to get a quick build out. this is the call I was making
I can dig a little deeper later today if this is an issue on my end. |
I think it was an oversight on my end. Looking at the MethodChannel being registered in the new version versus the old version, I think I copy/pasted from the wrong place. The error, I suspect, lies in |
Sounds good, thanks! |
Here's the PR to fix the problem. |
functionName: _functionName, | ||
parameters: parameters, | ||
) | ||
.then((response) => HttpsCallableResult._(response)); | ||
} on PlatformException catch (e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this catch remain, if an error does not fall into it?
Description
This change updates the existing
cloud_functions
plugin to usecloud_functions_platform_interface
.Related Issues
This addresses issue flutter/flutter#45299
It's also a drive-by fix for issue #95
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?