Skip to content

Fix fallthrough bug #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2020
Merged

Fix fallthrough bug #1884

merged 1 commit into from
Jan 28, 2020

Conversation

mehmetf
Copy link
Contributor

@mehmetf mehmetf commented Jan 27, 2020

This was caught during google3 roll. When confirmPasswordReset is called, it will throw a notImplemented error since there's no break in the case statement.

@mehmetf mehmetf requested a review from cyanglaz January 27, 2020 17:02
@mehmetf
Copy link
Contributor Author

mehmetf commented Jan 28, 2020

I need to submit this. It is a very simple fix and is blocking google3 rolls.

@mehmetf mehmetf merged commit 86c1024 into firebase:master Jan 28, 2020
@firebase firebase locked and limited conversation to collaborators Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mehmetf @googlebot