-
Notifications
You must be signed in to change notification settings - Fork 4k
[cloud_functions] web plugin implementation #1890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…_functions plugin.
…isolate it from following changes.
… interface to be a close reflection of the MethodChannel interface.
…pyright date in LICENSE.
It looks like the failure in build-ipas+drive-examples CHANNEL:master PLUGIN_SHARDING:--shardIndex 1 --shardCount 4 is not because of the plugin code but because that build check sets up for iOS 13.3 and then tries to run a simulator with iOS 13.2, which hasn't been installed. Who's in charge of configuring the check scripts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few documentation updates
packages/cloud_functions/cloud_functions_web/lib/cloud_functions_web.dart
Show resolved
Hide resolved
packages/cloud_functions/cloud_functions_web/lib/cloud_functions_web.dart
Outdated
Show resolved
Hide resolved
Is there support for other regions? Because in the used firebase package there is no support right now and the region parameter isn't used I think. Or am I wrong? |
This implementation delegates to the firebase plugin and you're right, the region parameter is silently ignored because there's not an obvious way to pass it down. |
You can set the region by doing |
packages/cloud_functions/cloud_functions_web/lib/cloud_functions_web.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @collinjackson can you take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR delivers the web implementation of the cloud_functions plugin. Note that although README.md refers to the example in cloud_functions, that can't actually be updated until this plugin gets published once (otherwise version resolving will fail).
Related Issues
Resolves issue 45299
Checklist
///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?