Skip to content

[cloud_functions] web plugin implementation #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jan 29, 2020
Merged

[cloud_functions] web plugin implementation #1890

merged 26 commits into from
Jan 29, 2020

Conversation

sbeitzel
Copy link
Contributor

@sbeitzel sbeitzel commented Jan 28, 2020

Description

This PR delivers the web implementation of the cloud_functions plugin. Note that although README.md refers to the example in cloud_functions, that can't actually be updated until this plugin gets published once (otherwise version resolving will fail).

Related Issues

Resolves issue 45299

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@sbeitzel
Copy link
Contributor Author

It looks like the failure in build-ipas+drive-examples CHANNEL:master PLUGIN_SHARDING:--shardIndex 1 --shardCount 4 is not because of the plugin code but because that build check sets up for iOS 13.3 and then tries to run a simulator with iOS 13.2, which hasn't been installed. Who's in charge of configuring the check scripts?

Copy link

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few documentation updates

@flowhorn
Copy link

Is there support for other regions? Because in the used firebase package there is no support right now and the region parameter isn't used I think. Or am I wrong?

@sbeitzel
Copy link
Contributor Author

This implementation delegates to the firebase plugin and you're right, the region parameter is silently ignored because there's not an obvious way to pass it down.

@harryterkelsen
Copy link

You can set the region by doing firebase.app().functions('region-name'): https://github.com/FirebaseExtended/firebase-dart/blob/master/lib/src/app.dart#L58

Copy link

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @collinjackson can you take a look?

Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@collinjackson collinjackson merged commit a0b51b5 into firebase:master Jan 29, 2020
@sbeitzel sbeitzel deleted the cf_pi_p2 branch January 29, 2020 16:01
@firebase firebase locked and limited conversation to collaborators Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants