Skip to content

[cloud_functions] Update example, README, depend on web plugin #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 4, 2020
Merged

[cloud_functions] Update example, README, depend on web plugin #1909

merged 5 commits into from
Feb 4, 2020

Conversation

sbeitzel
Copy link
Contributor

Description

This change updates the README.md with the correct version number of the cloud_functions plugin that imports the cloud_functions_web plugin. It also updates the cloud_functions example application with a web implementation.

Related Issues

flutter/flutter#45299

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@sbeitzel
Copy link
Contributor Author

Ugh. Kotlin.

@@ -1,6 +1,6 @@
name: cloud_functions
description: Flutter plugin for Cloud Functions.
version: 0.4.1+8
version: 0.4.1+9
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/cloud_functions/cloud_functions

flutter:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so that's how that happens. Okay, will do.

@sbeitzel
Copy link
Contributor Author

sbeitzel commented Feb 1, 2020

The build checks probably won't pass until PR 1910 gets merged. And, you know, never deploy on Friday.

@sbeitzel
Copy link
Contributor Author

sbeitzel commented Feb 1, 2020

Just looked at pub.dev and I realized that I'm going to have to bump the version number on package:cloud_functions_web one more time, to make the updated README get published. Since it's just a documentation change, I would think that 1.0.2+1 would be a good version, but previous analyzer checks have barfed on that version numbering style, insisting on a whole point increment (e.g. 1.0.3). Any thoughts?

@harryterkelsen
Copy link

I think a "+1" release will be fine. If the analyzer complains we can merge and see if we can fix the pubspec analyzer, since "+1" releases should be allowed

@sbeitzel
Copy link
Contributor Author

sbeitzel commented Feb 3, 2020

Yeah, here's the failure message:

Running version check for changed packages packages/cloud_functions/cloud_functions_web/pubspec.yaml incorrectly updated version. HEAD: 1.0.2+1, master: 1.0.2. Allowed versions: {2.0.0: NextVersionType.BREAKING_MAJOR, 1.1.0: NextVersionType.MINOR, 1.0.3: NextVersionType.PATCH}

@harryterkelsen
Copy link

It looks like the check only allows +N versions for versions that are 0.X.Y. That's fine, we can just bump to the next patch version: 1.0.3

Copy link

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harryterkelsen harryterkelsen merged commit d39ad94 into firebase:master Feb 4, 2020
@sbeitzel sbeitzel deleted the cloud_functions_example branch February 4, 2020 21:44
@firebase firebase locked and limited conversation to collaborators Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants