-
Notifications
You must be signed in to change notification settings - Fork 4k
[cloud_functions] Update example, README, depend on web plugin #1909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cloud_functions] Update example, README, depend on web plugin #1909
Conversation
Ugh. Kotlin. |
@@ -1,6 +1,6 @@ | |||
name: cloud_functions | |||
description: Flutter plugin for Cloud Functions. | |||
version: 0.4.1+8 | |||
version: 0.4.1+9 | |||
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/cloud_functions/cloud_functions | |||
|
|||
flutter: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also add a web:
section with a default_package:
like here: https://github.com/flutter/plugins/blob/master/packages/url_launcher/url_launcher/pubspec.yaml#L16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, so that's how that happens. Okay, will do.
The build checks probably won't pass until PR 1910 gets merged. And, you know, never deploy on Friday. |
… cloud_functions_example
Just looked at pub.dev and I realized that I'm going to have to bump the version number on |
I think a "+1" release will be fine. If the analyzer complains we can merge and see if we can fix the pubspec analyzer, since "+1" releases should be allowed |
Yeah, here's the failure message:
|
It looks like the check only allows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This change updates the README.md with the correct version number of the
cloud_functions
plugin that imports thecloud_functions_web
plugin. It also updates thecloud_functions
example application with a web implementation.Related Issues
flutter/flutter#45299
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?