Skip to content

[cloud_functions] Replace Kotlin with Java #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/cloud_functions/cloud_functions_web/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.0.2

Delete Kotlin no-op plugin and replace with Java.

## 1.0.1

Add no-op plugin implementations for iOS and Android to enable builds.
Expand Down
10 changes: 0 additions & 10 deletions packages/cloud_functions/cloud_functions_web/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,13 @@ group 'io.flutter.plugins.cloud_functions_web'
version '1.0'

buildscript {
ext.kotlin_version = '1.3.50'
repositories {
google()
jcenter()
}

dependencies {
classpath 'com.android.tools.build:gradle:3.5.0'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
}
}

Expand All @@ -22,22 +20,14 @@ rootProject.allprojects {
}

apply plugin: 'com.android.library'
apply plugin: 'kotlin-android'

android {
compileSdkVersion 28

sourceSets {
main.java.srcDirs += 'src/main/kotlin'
}
defaultConfig {
minSdkVersion 16
}
lintOptions {
disable 'InvalidPackage'
}
}

dependencies {
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
/*
* Copyright 2020 The Chromium Authors. All rights reserved.
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/

package io.flutter.plugins.cloud_functions_web;

import io.flutter.embedding.engine.plugins.FlutterPlugin;
import io.flutter.plugin.common.PluginRegistry.Registrar;

/** CloudFunctionsWebPlugin */
public class CloudFunctionsWebPlugin implements FlutterPlugin {
@Override
public void onAttachedToEngine(FlutterPluginBinding flutterPluginBinding) {}

public static void registerWith(Registrar registrar) {}

@Override
public void onDetachedFromEngine(FlutterPluginBinding binding) {}
}

This file was deleted.

2 changes: 1 addition & 1 deletion packages/cloud_functions/cloud_functions_web/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: cloud_functions_web
description: The web implementation of cloud_functions
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/cloud_functions/cloud_functions_web
version: 1.0.1
version: 1.0.2

flutter:
plugin:
Expand Down