Skip to content

[all] Add desktop availability to the README. #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2020

Conversation

cbenhagen
Copy link
Contributor

Description

Add desktop availability column to the README.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@cbenhagen cbenhagen changed the title Add desktop availability to the README. [All] Add desktop availability to the README. Feb 19, 2020
@cbenhagen cbenhagen requested a review from ditman February 19, 2020 19:37
@cbenhagen cbenhagen changed the title [All] Add desktop availability to the README. [all] Add desktop availability to the README. Feb 19, 2020
Copy link
Contributor

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not sure how we're going to scale up that table as new platforms get added! :P

@ditman ditman requested a review from collinjackson February 19, 2020 20:41
@cbenhagen
Copy link
Contributor Author

@ditman I hope we will soon face this problem ;) I am looking forward to Linux and Windows versions of the plugins.

@ditman ditman merged commit 0592027 into firebase:master Feb 20, 2020
@firebase firebase locked and limited conversation to collaborators Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants