Skip to content

Add pedantic to all Firebase plugins #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 24, 2020
Merged

Add pedantic to all Firebase plugins #2040

merged 4 commits into from
Feb 24, 2020

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Feb 21, 2020 •
edited
Loading

Description

Adds pedantic dependencies for all Firebase plugins' analysis_options.

Related Issues

Copy of flutter/plugins#2543

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

cyanglaz
cyanglaz approved these changes Feb 22, 2020
View reviewed changes
Copy link

@cyanglaz cyanglaz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please make sure the version updates are correct before merging.
Thanks a lot for doing this!

packages/cloud_firestore/cloud_firestore/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## 0.13.4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be 0.13.3+1?

Suggested change
## 0.13.4
## 0.13.3+1

packages/cloud_firestore/cloud_firestore/pubspec.yaml Outdated
@@ -3,7 +3,7 @@ description:
Flutter plugin for Cloud Firestore, a cloud-hosted, noSQL database with
live synchronization and offline support on Android and iOS.
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/cloud_firestore/cloud_firestore
version: 0.13.3
version: 0.13.4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 0.13.4
version: 0.13.3+1

packages/cloud_functions/cloud_functions/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## 0.4.3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 0.4.3
## 0.4.2+1

packages/cloud_functions/cloud_functions/pubspec.yaml Outdated
@@ -1,6 +1,6 @@
name: cloud_functions
description: Flutter plugin for Cloud Functions.
version: 0.4.2
version: 0.4.3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 0.4.3
version: 0.4.2+1

packages/firebase_auth/firebase_auth/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## 0.15.6
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 0.15.6
## 0.15.5+1

packages/firebase_auth/firebase_auth/pubspec.yaml Outdated
@@ -3,7 +3,7 @@ description: Flutter plugin for Firebase Auth, enabling Android and iOS
authentication using passwords, phone numbers and identity providers
like Google, Facebook and Twitter.
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_auth/firebase_auth
version: 0.15.5
version: 0.15.6
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 0.15.6
version: 0.15.5+1

packages/firebase_core/firebase_core/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## 0.4.5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 0.4.5
## 0.4.4+1

packages/firebase_core/firebase_core/pubspec.yaml Outdated
@@ -2,7 +2,7 @@ name: firebase_core
description: Flutter plugin for Firebase Core, enabling connecting to multiple
Firebase apps.
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_core/firebase_core
version: 0.4.4
version: 0.4.5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 0.4.5
version: 0.4.4+1

packages/firebase_crashlytics/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## 0.1.4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 0.1.4
## 0.1.3+1

packages/firebase_crashlytics/pubspec.yaml Outdated
@@ -2,7 +2,7 @@ name: firebase_crashlytics
description:
Flutter plugin for Firebase Crashlytics. It reports uncaught errors to the
Firebase console.
version: 0.1.3
version: 0.1.4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 0.1.4
version: 0.1.3+1

collinjackson
collinjackson approved these changes Feb 22, 2020
View reviewed changes
Copy link
Contributor

@collinjackson collinjackson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once @cyanglaz's comments are addressed and tests pass. Thank you SO much.

@bparrishMines bparrishMines merged commit ca7eb26 into firebase:master Feb 24, 2020
@bparrishMines bparrishMines deleted the add_pedantic branch February 24, 2020 21:09
@firebase firebase locked and limited conversation to collaborators Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@collinjackson collinjackson collinjackson approved these changes

@cyanglaz cyanglaz cyanglaz approved these changes

@amirh amirh Awaiting requested review from amirh

@kroikie kroikie Awaiting requested review from kroikie

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bparrishMines @collinjackson @cyanglaz @googlebot