Skip to content

Replace deprecated getFlutterEngine calls on Android #2050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 2, 2020
Merged

Replace deprecated getFlutterEngine calls on Android #2050

merged 7 commits into from
Mar 2, 2020

Conversation

creativecreatorormaybenot
Copy link
Contributor

Description

This pull request resolves what was mentioned in #2049.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, this is not a breaking change.

@creativecreatorormaybenot creativecreatorormaybenot changed the title Replace deprecated getFlutterEngine call on Android Replace deprecated getFlutterEngine calls on Android Feb 24, 2020
collinjackson
collinjackson approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you address the merge conflicts?

@creativecreatorormaybenot
Copy link
Contributor Author

@collinjackson Yikes, I should have considered that PR before.

Done 👍

@collinjackson collinjackson merged commit ac5ddec into firebase:master Mar 2, 2020
@creativecreatorormaybenot creativecreatorormaybenot deleted the deprecated-calls branch March 2, 2020 12:30
@creativecreatorormaybenot creativecreatorormaybenot mentioned this pull request Mar 12, 2020
Merged
12 tasks
@firebase firebase locked and limited conversation to collaborators Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@collinjackson collinjackson collinjackson approved these changes

@amirh amirh Awaiting requested review from amirh

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

@kroikie kroikie Awaiting requested review from kroikie

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@creativecreatorormaybenot @collinjackson @googlebot