Skip to content

[firebase_core_platform_interface] Migrate to plugin_platform_interface #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 27, 2020
Merged

[firebase_core_platform_interface] Migrate to plugin_platform_interface #2065

merged 4 commits into from
Feb 27, 2020

Conversation

harryterkelsen
Copy link

Description

Migrates firebase_core_platform_interface to use plugin_platform_interface

Related Issues

Partially addresses #2064

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@ditman ditman linked an issue Feb 26, 2020 that may be closed by this pull request
Copy link
Contributor

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wowza! Great stuff, thanks for addressing this!

Analyzer is complaining about an unused import, other than that this looks good to go!

@@ -1,3 +1,6 @@
## 1.0.3+1

* Migrate to package:plugin_platform_interface.
## 1.0.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 1.0.3
## 1.0.3

@harryterkelsen harryterkelsen merged commit a87bd8c into firebase:master Feb 27, 2020
@harryterkelsen harryterkelsen deleted the tech-debt-updates branch February 27, 2020 19:25
@firebase firebase locked and limited conversation to collaborators Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[firebase_core] Use PlatformInterface
4 participants