[firebase_admob] Support Native Ads on iOS #2106

bparrishMines · 2020-03-02T20:03:08Z

Description

Add support for Native Ads on iOS

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

… native_ads

…eAdView with custom layout.

…o native_ads

… native_ads

…o native_ads

…o native_ads_ios2

… native_ads_ios2

…e into native_ads_ios2

bparrishMines · 2020-03-06T20:44:43Z

packages/firebase_admob/example/ios/Runner.xcodeproj/project.pbxproj

@@ -8,11 +8,11 @@



We don't typically include this file, but I need it to add UnifiedNativeAdView.xib to the xcode project. Otherwise, the app crashes when creating a NativeAd.

amirh · 2020-03-10T17:06:45Z

@blasten

blasten · 2020-03-11T16:26:20Z

packages/firebase_admob/README.md

+Android Native Ads require a class that implements `NativeAdFactory` which implements `createNativeAd(
 [UnifiedNativeAd](https://developers.google.com/android/reference/com/google/android/gms/ads/formats/UnifiedNativeAd) nativeAd,
 Map<String, Options> customOptions)` and returns a


This doesn't seem to render using GH markdown. Maybe add a link below to UnifiedNativeAd.

done. I changed it to explain the method with the provided links. The signature of the method is still in the example below.

blasten · 2020-03-11T16:28:25Z

packages/firebase_admob/README.md

@@ -285,8 +285,53 @@ An example of displaying a `UnifiedNativeAd` with a `UnifiedNativeAdView` can be
 a custom layout and displays the test Native ad.

 ### iOS
+Native Ads for iOS require a class that implements the protocol `FLTNativeAdFactory` which has a
+single method `createNativeAd:customOptions:`.


nit: the example below has a nativeAd argument too.

I was following the naming structure from apple docs. Example setObject:forKey: doesn't keep the name of the first object:
https://developer.apple.com/documentation/foundation/nsmutabledictionary/1411616-setobject?language=objc

I wasn't really sure what the best shorthand form for an objective c method was.

blasten · 2020-03-11T16:29:36Z

packages/firebase_admob/README.md

+@end
+```
+
+Once there is an implementation of `FLTNativeAdFactory` it must be added to the


nit: comma before it?

blasten · 2020-03-11T16:38:39Z

packages/firebase_admob/example/ios/Runner/AppDelegate.m

+
+  // In order for the SDK to process touch events properly, user interaction
+  // should be disabled.
+  adView.callToActionView.userInteractionEnabled = NO;


is this a requirement for Flutter apps? Is this meant to be set by the iOS embedding?

I think this is required for any app that uses UnifiedNativeAdView. Setting this to NO is to guarantee that UnifiedNativeAdView receives the touch event and not the subview. Otherwise, the adview wouldn't open the link.

blasten · 2020-03-11T16:46:13Z

packages/firebase_admob/ios/Classes/FLTFirebaseAdMobPlugin.m

+                              nativeAdFactory:_nativeAdFactories[factoryId]
+                                customOptions:customOptions];
+
+  if (nativeAd.status != CREATED) {


should there be a return within this path? result seems to be called twice if the ad isn't created.

Yea there should be. I added one to the end of the if statement.

blasten · 2020-03-11T16:52:19Z

packages/firebase_admob/ios/Classes/FLTMobileAd.m

+@implementation FLTMobileAdWithView
+- (UIView *)adView {
+  // We cause a crash if this method is not overriden by subclasses.
+  [self doesNotRecognizeSelector:_cmd];


Are developers going to be extending FLTMobileAdWithView on their own?

Nope. Plugin users should never see this, but the plugin's maintainer would need to know this. I left this note so that another plugin maintainer knows why we cause a crash in this method.

sounds good

blasten · 2020-03-11T16:56:27Z

packages/firebase_admob/ios/Classes/FLTMobileAd.m

+  [screen addSubview:self.adView];
+
+#if defined(__IPHONE_11_0) && (__IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_11_0)
+  if (@available(ios 11.0, *)) {


could you add a comment about why the constraints are needed on iOS 11?

blasten · 2020-03-11T16:58:55Z

packages/firebase_admob/ios/Classes/FLTMobileAd.m

+  }
+#endif
+
+  CGFloat x =


is this horizontally centering the ad and aligning it to the bottom? Could you add a comment?

blasten · 2020-03-11T17:07:52Z

This is looking great! just a few nits.

blasten · 2020-03-11T17:10:21Z

packages/firebase_admob/example/ios/Runner/AppDelegate.m

+  // These assets are not guaranteed to be present. Check that they are before
+  // showing or hiding them.


does this depend on the ad that is being displayed?

Yes this depends on the information that is provided in the UnifiedNativeAd. Some ads may have this item and others won't.

I see. Suggestion: what about we add a link to https://developers.google.com/admob/ios/native/advanced in a comment?

blasten

LGTM + suggestion

blasten · 2020-03-16T18:00:20Z

packages/firebase_admob/example/ios/Runner/AppDelegate.m

+  // These assets are not guaranteed to be present. Check that they are before
+  // showing or hiding them.


I see. Suggestion: what about we add a link to https://developers.google.com/admob/ios/native/advanced in a comment?

bparrishMines added 30 commits September 12, 2019 16:11

Start of Android version of NativeAds

0d0c05f

Android side of nativeads

aad39a2

Add dart code for Native Ads

08bab20

Add documentation and throw exception on iOS

3f0978e

Version bump

0e073b4

Add documentation to README

2cc277a

Update changelog and README and dispose ad

25cbc59

Small comment change

10bcb6c

Merge branch 'master' of github.com:FirebaseExtended/flutterfire into…

d6805db

… native_ads

Formatting and documentation

7b16385

Add note about only supporting android

daeb8ec

Macro for testAdUnitId

5d19c10

Show Ad content

c69e94c

Remove unused variable and view configuration

abc4fee

Update documentation

73b0337

Show a UnifiedNativeAd

20e6cb6

Merge branch 'master' of github.com:FirebaseExtended/flutterfire into…

03300ad

… native_ads

Use NatvieAdFactory interface, reorder main.dart, create UnifiedNativ…

2211c63

…eAdView with custom layout.

update readme

ba01270

Documentation and formatting

2cc1a0b

Merge branch 'native_ads' of github.com:bparrishMines/flutterfire int…

bf94993

…o native_ads

Merge branch 'master' of github.com:FirebaseExtended/flutterfire into…

af49fe7

… native_ads

Fix interstitials

1467913

Formatting

b5392c9

Test native ad

d45f24d

Add customOptions

ea4aef0

Set native ad factory for plugin instance

2fbe0ee

Update README

e15649e

Merge branch 'master' of github.com:FirebaseExtended/flutterfire into…

c8e7796

… native_ads

Merge branch 'native_ads' of github.com:bparrishMines/flutterfire int…

3b43c89

…o native_ads

bparrishMines added 8 commits March 4, 2020 11:54

Add static key and null check in unregisterNativeAdFactory

287a756

Formatting and Documentation

4eba72c

Add todo with lifecycle issue

cf2511c

Merge branch 'native_ads' of github.com:bparrishMines/flutterfire int…

29b2063

…o native_ads_ios2

Merge branch 'master' of github.com:FirebaseExtended/flutterfire into…

48acc40

… native_ads_ios2

Merge branch 'native_ads_ios2' of github.com:bparrishMines/flutterfir…

c9e10b8

…e into native_ads_ios2

Fix showing the view

a583c5d

Documentation for iOS

cd7d5f5

bparrishMines commented Mar 6, 2020

View reviewed changes

bparrishMines added 6 commits March 6, 2020 18:24

Documentation and small change to example

4a4706f

Handle errors when setting a native ad factory

0897e36

crash if method not overriden

717dba2

Add comment

8270b94

Fix banner view showing

1a4faee

Formatting

3b30a1e

bparrishMines changed the title ~~[WIP] Native ads ios2~~ [firebase_admob] Support Native Ads on iOS Mar 9, 2020

Format with clang 700

c7448b9

blasten reviewed Mar 11, 2020

View reviewed changes

Review comments

ab88c59

blasten approved these changes Mar 16, 2020

View reviewed changes

Add comment about example code location

dfd19f5

bparrishMines merged commit f330907 into firebase:master Mar 17, 2020

bparrishMines deleted the native_ads_ios2 branch March 17, 2020 17:05

This was referenced Mar 17, 2020

Support AdMob Native Ads Advanced in overlays flutter/flutter#35082

Closed

[firebase_admob] Bump admob version for iOS Native Ads #2192

Merged

thibaultzanini mentioned this pull request Mar 28, 2020

Google native ads integrated into a Flutter widget tree flutter/flutter#12114

Closed

firebase locked and limited conversation to collaborators Aug 2, 2020

		// These assets are not guaranteed to be present. Check that they are before
		// showing or hiding them.

[firebase_admob] Support Native Ads on iOS #2106

[firebase_admob] Support Native Ads on iOS #2106

Uh oh!

Conversation

bparrishMines commented Mar 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Checklist

Breaking Change

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amirh commented Mar 10, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blasten commented Mar 11, 2020

Uh oh!

blasten Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blasten left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bparrishMines commented Mar 2, 2020 •

edited

Loading

blasten Mar 11, 2020 •

edited

Loading