-
Notifications
You must be signed in to change notification settings - Fork 4k
[firebase_messaging] Updated Getting Started #3069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated getting started instructions to fix background notifications.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Updated CHANGELOG.md** |
|
||
```java | ||
```kt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no package io.flutter.plugins.firebasemessagingexample;
in Application.kt
and FirebaseCloudMessagingPluginRegistrant.kt
code above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont know how that disappeared. thanks a lot. I know they wont merge this pull request + i dont use flutter anymore. I'm just going to close this request :/
Description
The current getting started guide for the firebase_messaging is outdated. The background notification does not work without this change to the getting started guide
Related Issues
[#2897] This update to the Readme fixes this issue some people are having where background notifications don't work along with this error message: "Fatal: failed to find callback"
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?