[firebase_messaging] fixed platform dependency error

[preetjdp]

Description

This PR solves the package firebase_messaging from working flutter 1.22.0-2.0.pre.36, the problem was related to the package platform, the solution was to remove the package.

Related Issues

• [Messaging] flutter_driver and firebase_messaging are incompatible #3312

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
• My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
• All existing and new tests are passing.
• I updated/added relevant documentation (doc comments with ///).
• The analyzer (flutter analyze) does not report any problems on my PR.
• I read and followed the Flutter Style Guide.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
• I updated CHANGELOG.md to add a description of the change.
• I signed the CLA.
• I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

• Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
• No, this is not a breaking change.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[preetjdp]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[acoutts]

Looking forward to this 👍 had to downgrade from Dev to Beta channel.

[acoutts]

@preetjdp I think the conflicting change in pubspec is due to the recent commit here where they fixed up the local example include paths. I think if you merge from the latest master here it will fix it up.

[preetjdp]

Hey @acoutts you can run the package from my branch, I've verified it from my end and it works

firebase_messaging:
    git:
      url: git://github.com/preetjdp/flutterfire.git
      ref: fix-3312
      path: packages/firebase_messaging

[preetjdp]

@acoutts The actual fix is just a one-line tweak to remove this dependency
https://github.com/FirebaseExtended/flutterfire/blob/7eb9e21f82a09c5cecebfc231b256545cf1ce073/packages/firebase_messaging/pubspec.yaml#L18

I'm sure @Salakar is aware of this and thus blocked the merge of the PR.

[Salakar]

I blocked this one as it's incomplete, analyzer is failing as theres some usages of the 'platform' dependency still being used in the code that also need replacing. Was going to reply but slipped my mind sorry 😅

[Salakar]

This has been resolved on master. Thanks for the PR.