feat(auth): add reauthenticateWithProvider
#9570
Conversation
Lyokone
changed the title
reauthenticateWithProviderreauthenticateWithProvider
|
@russellwheatley I've added documentation (same as in the Android documentation part 6 which is really sparse) |
| /// On Web you should use [linkWithPopup] instead. | ||
| /// | ||
| /// A [FirebaseAuthException] maybe thrown with the following error code: | ||
| /// - **provider-already-linked**: |
There was a problem hiding this comment.
Not sure these codes are correct for this operation? Copied from somewhere else?
These don't belong here afaik;
- provider-already-linked
- credential-already-in-use
- email-already-in-use
(same again for popup api below this one)
There was a problem hiding this comment.
Fixed :)
Also removed the phone errors since it would use reauthenticateWithCredentials
Lyokone
force-pushed
the
feat/reauthenticate
branch
from
56d221d to
907dcc9
Compare
|
So if I am correct @Lyokone, you also added reauthenticateWithPopup (this method is also in the docs), but I can't really use this method because it wasn't added to the main firebae_auth package, only to the firebase_auth_platfrom_interface and firebase_auth_web. So could you add that as well? |
|
@prggTheProgrammer Thanks for the heads up, I've created a PR to fix that :) |
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Closes #9566
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?