fix(dynamic-link): fix unhandled exception caused by "additionalData" map #9900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
additionalData
property as part of exception here. This causes an uncaught exception here because it is expectingMap<String, String>
type. I've updated to allow nested maps (i.e.Map<String, Object>
).The other issue I want to highlight is
code
andmessage
. They are really unhelpful. On the other hand,additionalData
has more accurate information.As you can see from the below noted,

additionalData
has theadditionalData.message
: "Requested entity was not found" compared to themessage
: "An unknown error has occurred".We should think about how we can include
additionalData
in the exception, this is not the first time descriptive messages have been obfuscated from the user.Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?