Skip to content

fix(dynamic-link): fix unhandled exception caused by "additionalData" map #9900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 16, 2022

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Nov 10, 2022

Description

  1. We send additionalData property as part of exception here. This causes an uncaught exception here because it is expecting Map<String, String> type. I've updated to allow nested maps (i.e. Map<String, Object>).

The other issue I want to highlight is code and message. They are really unhelpful. On the other hand, additionalData has more accurate information.

As you can see from the below noted, additionalData has the additionalData.message: "Requested entity was not found" compared to the message: "An unknown error has occurred".
Screenshot 2022-11-10 at 12 58 00

We should think about how we can include additionalData in the exception, this is not the first time descriptive messages have been obfuscated from the user.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone
Copy link
Contributor

Lyokone commented Nov 14, 2022

Should we create another issue to add more information to the base error message?

@russellwheatley
Copy link
Member Author

@Lyokone yes, that's a good idea. Here is the issue: #9943

@russellwheatley russellwheatley merged commit 4c72b54 into master Nov 16, 2022
@russellwheatley russellwheatley deleted the @russell/dynamic-9829 branch November 16, 2022 12:42
@firebase firebase locked and limited conversation to collaborators Dec 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants