Skip to content

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jun 13, 2025

Outstanding work:

  • Still some uses of FDL in other product qs that will need to be removed

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @ncooke3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request removes the configuration entry for the Firebase Dynamic Links quickstart from the project's .opensource/project.json file. This change likely reflects the quickstart's removal or deprecation from the project.

Highlights

  • Configuration Update: Removed the entry for the Firebase Dynamic Links quickstart README from the .opensource/project.json configuration file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the reference to dynamiclinks/README.md from the .opensource/project.json configuration file. This change aligns with the stated intent to remove the Firebase Dynamic Links quickstart. The review includes a comment on the deleted line to prompt verification that all associated files and directories for the Dynamic Links quickstart are also being removed to ensure the completeness and consistency of the deprecation.

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to wait for Firebase 12, since FDL is already deprecated and no one should be starting with it.

@ncooke3
Copy link
Member Author

ncooke3 commented Jun 13, 2025

No need to wait for Firebase 12, since FDL is already deprecated and no one should be starting with it.

Good point!

@ncooke3 ncooke3 merged commit 2970fe0 into main Jun 13, 2025
5 checks passed
@ncooke3 ncooke3 deleted the nc/delete-fdl branch June 13, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants