Skip to content

Update phone auth snippets with RecaptchaVerifier parameter reordering #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Update phone auth snippets with RecaptchaVerifier parameter reordering #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3add7b3
Update phone auth snippets with RecaptchaVerifier parameter reordering
ch5zzy Jun 13, 2023
bb1569b
Update auth-next dependency to v10
ch5zzy Jun 14, 2023
ef4223e
Merge branch 'master' into fix-recaptcha-verifier-snippets
ch5zzy Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion auth-next/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
},
"license": "Apache-2.0",
"dependencies": {
"firebase": "^9.22.2"
"firebase": "^10.0.0"
}
}
10 changes: 5 additions & 5 deletions auth-next/phone-auth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@ function recaptchaVerifierInvisible() {
const { getAuth, RecaptchaVerifier } = require("firebase/auth");

const auth = getAuth();
window.recaptchaVerifier = new RecaptchaVerifier('sign-in-button', {
window.recaptchaVerifier = new RecaptchaVerifier(auth, 'sign-in-button', {
'size': 'invisible',
'callback': (response) => {
// reCAPTCHA solved, allow signInWithPhoneNumber.
onSignInSubmit();
}
}, auth);
});
// [END auth_phone_recaptcha_verifier_invisible]
}

Expand All @@ -30,7 +30,7 @@ function recaptchaVerifierVisible() {
const { getAuth, RecaptchaVerifier } = require("firebase/auth");

const auth = getAuth();
window.recaptchaVerifier = new RecaptchaVerifier('recaptcha-container', {
window.recaptchaVerifier = new RecaptchaVerifier(auth, 'recaptcha-container', {
'size': 'normal',
'callback': (response) => {
// reCAPTCHA solved, allow signInWithPhoneNumber.
Expand All @@ -40,7 +40,7 @@ function recaptchaVerifierVisible() {
// Response expired. Ask user to solve reCAPTCHA again.
// ...
}
}, auth);
});
// [END auth_phone_recaptcha_verifier_visible]
}

Expand All @@ -49,7 +49,7 @@ function recaptchaVerifierSimple() {
const { getAuth, RecaptchaVerifier } = require("firebase/auth");

const auth = getAuth();
window.recaptchaVerifier = new RecaptchaVerifier('recaptcha-container', {}, auth);
window.recaptchaVerifier = new RecaptchaVerifier(auth, 'recaptcha-container', {});
// [END auth_phone_recaptcha_verifier_simple]
}

Expand Down
4 changes: 2 additions & 2 deletions snippets/auth-next/phone-auth/auth_phone_recaptcha_verifier_invisible.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
import { getAuth, RecaptchaVerifier } from "firebase/auth";

const auth = getAuth();
window.recaptchaVerifier = new RecaptchaVerifier('sign-in-button', {
window.recaptchaVerifier = new RecaptchaVerifier(auth, 'sign-in-button', {
'size': 'invisible',
'callback': (response) => {
// reCAPTCHA solved, allow signInWithPhoneNumber.
onSignInSubmit();
}
}, auth);
});
// [END auth_phone_recaptcha_verifier_invisible_modular]
2 changes: 1 addition & 1 deletion snippets/auth-next/phone-auth/auth_phone_recaptcha_verifier_simple.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
import { getAuth, RecaptchaVerifier } from "firebase/auth";

const auth = getAuth();
window.recaptchaVerifier = new RecaptchaVerifier('recaptcha-container', {}, auth);
window.recaptchaVerifier = new RecaptchaVerifier(auth, 'recaptcha-container', {});
// [END auth_phone_recaptcha_verifier_simple_modular]
4 changes: 2 additions & 2 deletions snippets/auth-next/phone-auth/auth_phone_recaptcha_verifier_visible.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import { getAuth, RecaptchaVerifier } from "firebase/auth";

const auth = getAuth();
window.recaptchaVerifier = new RecaptchaVerifier('recaptcha-container', {
window.recaptchaVerifier = new RecaptchaVerifier(auth, 'recaptcha-container', {
'size': 'normal',
'callback': (response) => {
// reCAPTCHA solved, allow signInWithPhoneNumber.
Expand All @@ -18,5 +18,5 @@ window.recaptchaVerifier = new RecaptchaVerifier('recaptcha-container', {
// Response expired. Ask user to solve reCAPTCHA again.
// ...
}
}, auth);
});
// [END auth_phone_recaptcha_verifier_visible_modular]